myfaces-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Gerhard Petracek (JIRA)" <...@myfaces.apache.org>
Subject [jira] [Resolved] (MYFACES-3798) protected-view handling is broken
Date Mon, 07 Oct 2013 08:56:42 GMT

     [ https://issues.apache.org/jira/browse/MYFACES-3798?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Gerhard Petracek resolved MYFACES-3798.
---------------------------------------

    Resolution: Not A Problem

agreed. i had to check a 3rd party code + a test which showed the issue. however, the real
issue is in the 3rd party code (a quite hidden and dirty reassignment of _protectedViewsSet
via reflection).

> protected-view handling is broken
> ---------------------------------
>
>                 Key: MYFACES-3798
>                 URL: https://issues.apache.org/jira/browse/MYFACES-3798
>             Project: MyFaces Core
>          Issue Type: Bug
>          Components: JSR-344
>    Affects Versions: 2.2.0
>            Reporter: Gerhard Petracek
>            Assignee: Leonardo Uribe
>
> the result of ViewHandlerImpl#getProtectedViewsUnmodifiable isn't spec. compliant.
> addProtectedView and removeProtectedView don't recreate _unmodifiableProtectedViewsSet.
at the end of both we need:
> _unmodifiableProtectedViewsSet = Collections.unmodifiableSet(_protectedViewsSet);
> or we always return Collections.unmodifiableSet(_protectedViewsSet); in ViewHandlerImpl#getProtectedViewsUnmodifiable



--
This message was sent by Atlassian JIRA
(v6.1#6144)

Mime
View raw message