myfaces-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Leonardo Uribe (JIRA)" <...@myfaces.apache.org>
Subject [jira] [Commented] (MYFACES-3587) Not existing viewId will not be handled
Date Thu, 17 Oct 2013 15:29:42 GMT

    [ https://issues.apache.org/jira/browse/MYFACES-3587?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13798007#comment-13798007
] 

Leonardo Uribe commented on MYFACES-3587:
-----------------------------------------

Added web config param org.apache.myfaces.STRICT_JSF_2_VIEW_NOT_FOUND and fixed case when
org.apache.myfaces.SUPPORT_JSP_AND_FACES_EL=false (catch filenotfoundexception and throw 404
response, and if vdl is not found throw 404 response too)

> Not existing viewId will not be handled
> ---------------------------------------
>
>                 Key: MYFACES-3587
>                 URL: https://issues.apache.org/jira/browse/MYFACES-3587
>             Project: MyFaces Core
>          Issue Type: Bug
>          Components: General
>    Affects Versions: 2.1.8
>         Environment: Jetty/Tomcat, JUEL, CODI, ExtVal
>            Reporter: Thomas Andraschko
>            Assignee: Leonardo Uribe
>             Fix For: 2.1.13
>
>
> If i call a page, which does not exist, following exceptions occurs: Cannot reset buffer
after response has been committed.
> After digging deeper into this problem, i found out that getViewHandlerSupport()#calculateViewId
returns null and the JspViewDeclarationLanguageStrategy will be used -> 
> Cannot reset buffer after response has been committed. 
> occurs.
> I added a null check for the logicalViewId in RestoreViewExecutor#execute to call HttpServletResponse#sendError.
> It does not work as expected because it just renders the errorPage and no redirect will
be done.
> Why there is not such null check?
> Is it possible to add this check and redirect to the web.xml defined 404 or common error
page? Or should it use the ErrorHandler?



--
This message was sent by Atlassian JIRA
(v6.1#6144)

Mime
View raw message