myfaces-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Leonardo Uribe (JIRA)" <...@myfaces.apache.org>
Subject [jira] [Commented] (MYFACES-3728) "javax.faces.partial.execute=@none" still process "javax.faces.source" component
Date Tue, 09 Jul 2013 15:33:49 GMT

    [ https://issues.apache.org/jira/browse/MYFACES-3728?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13703380#comment-13703380
] 

Leonardo Uribe commented on MYFACES-3728:
-----------------------------------------

Checking the jsdoc spec of jsf.ajax.request it says:

"... If the keyword @none is present, do not create and send the post data argument javax.faces.partial.execute.
..."

later on:

"... If the keyword @none is present, do not create and send the post data argument javax.faces.partial.render.
..."

MyFaces is doing it right. But it also says this:

"... If the keyword @all is present, create the post data argument with the name javax.faces.partial.execute
and the value @all ..."

So in theory it is valid to pass the keyword inside javax.faces.partial.execute and javax.faces.partial.render
fields. 

I think it is a topic more related to interpretation. The spec is clear saying that is @none
keyword is used, it is responsibility of the client behavior renderer to omit the request
parameters. 

In this case and being strict with the spec, I think the fix should be done at primefaces,
but I don't see any reason why don't allow the case in MyFaces. Probably it is a good idea,
because in theory developers should be able to invent new keywords, and overriding PartialViewContext
make things work. 

In my opinion, it is not a bug, but it looks more like a clarification over the possible allowed
values for these two request parameters. I think we can fix it on the next version.
                
> "javax.faces.partial.execute=@none" still process "javax.faces.source" component
> --------------------------------------------------------------------------------
>
>                 Key: MYFACES-3728
>                 URL: https://issues.apache.org/jira/browse/MYFACES-3728
>             Project: MyFaces Core
>          Issue Type: Bug
>    Affects Versions: 2.1.10
>            Reporter: Thomas Andraschko
>
> i found a weird issue that if i use p:ajax on inputText with process="@none", the InputTextRenderer#decode
method will be still invoked.
> This works fine with f:ajax in myfaces and mojarra.
> p:ajax only works expected on mojarra.
> The only difference i found is, that p:ajax sends the "javax.faces.partial.execute" param
and f:ajax not.
> Here is a list with the post params (without my inputs):
> PrimeFaces:
> javax.faces.ViewState=N%2F6uUZMB9%2BPXSBTJVus5p6rncWDWwUAgQ9UIOweKuerVM0Z7
> javax.faces.partial.ajax=true
> javax.faces.source=xxx
> javax.faces.partial.execute=%40none
> javax.faces.partial.render=%40none
> javax.faces.behavior.event=change
> javax.faces.partial.event=change
> form_SUBMIT=1
> MyFaces:
> javax.faces.ViewState=EHCQlskNw%2BLXSBTJVus5pyzjdxWpT%2B72t7rvnK11Nffi10%2Bl
> javax.faces.partial.ajax=true
> javax.faces.source=xxx
> javax.faces.behavior.event=change
> javax.faces.partial.event=change
> javax.faces.windowId=2cc
> form_SUBMIT=1
> form=form

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message