Mailing-List: contact dev-help@myfaces.apache.org; run by ezmlm
Precedence: bulk
Reply-To: "MyFaces Development" <dev@myfaces.apache.org>
Received-SPF: pass (nike.apache.org: domain of zhao.koh@gmail.com designates
 209.85.210.47 as permitted sender)
Content-Type: text/plain; charset=iso-8859-1
Mime-Version: 1.0 (Apple Message framework v1283)
Subject: Re: MyFaces 2.1.8 - Issues with composite component renderFacet
From: Zhao Koh <zhao.koh@gmail.com>
In-Reply-To: 
 <CABujnVcC458mbqN+vfAXWOHub=mNArPrG5kPviU2bPDZs32WtQ@mail.gmail.com>
Date: Fri, 21 Dec 2012 18:15:12 +1100
Content-Transfer-Encoding: quoted-printable
Message-Id: <AA2EDE19-5C67-4CD3-8D6F-F9AC7B9AC599@gmail.com>
References: <60517876-ED01-413E-8228-FF2CBA1674B7@gmail.com>
 <CABujnVcC458mbqN+vfAXWOHub=mNArPrG5kPviU2bPDZs32WtQ@mail.gmail.com>
To: "MyFaces Development" <dev@myfaces.apache.org>

Thanks Leonardo for the prompt response.=20

I did a test today by removing prependId=3D"false" from my form, but it =
does not seem to fix the issue with v2.1.8.

One question - how can I re-open the JIRA ticket MYFACES-3373? I have =
registered myself in JIRA but unable to re-open the issue which is =
closed at the moment.

Leonardo, if you have any interim workaround for this issue, please let =
me know.

Thanks again.

Regards,
Zhao


On 21/12/2012, at 4:32 AM, Leonardo Uribe wrote:

> Hi
>=20
> It is probably a bug, just that it is hard to see it at first view. I
> can't reproduce it,
> but I found the change that create the problem:
>=20
> https://issues.apache.org/jira/browse/MYFACES-3373
>=20
> UIForm.createUniqueId should take into account prependId logic
>=20
> The problem is related to
>=20
> https://issues.apache.org/jira/browse/MYFACES-3663
>=20
> UIViewRoot.createUniqueId() should generate unique ids for all the
> component tree.
>=20
> I think in your case there should be one component programatically =
added by a
> third party library that changes the order of the generated ids. If
> the order changes,
> the action is not executed the first time. I suppose if you set
> prependId to true it
> will work.
>=20
> Please reopen MYFACES-3373 in order to fix it properly. I think the
> solution is only
> apply the code when prependId is false AND the seed is not provided.
>=20
> Thanks for the report. Issues like this one are hard to find.
>=20
> regards,
>=20
> Leonardo Uribe
>=20
> 2012/12/20 Zhao Koh <zhao.koh@gmail.com>:
>> Hi all,
>>=20
>> I am currently using MyFaces 2.1.8 but discovered an issue with =
composite
>> component renderFacet - and this issue started at version 2.1.4.
>>=20
>> The following describes the problem:
>>=20
>> I have a composite component called buttonSelectBox that uses
>> composite:renderFacet to inject content from client - nothing fancy, =
only a
>> span that surrounds the content.
>>=20
>>=20
>> <html xmlns=3D"http://www.w3.org/1999/xhtml"
>>        xmlns:h=3D"http://java.sun.com/jsf/html"
>>        xmlns:f=3D"http://java.sun.com/jsf/core"
>>        xmlns:c=3D"http://java.sun.com/jsp/jstl/core"
>>        xmlns:ui=3D"http://java.sun.com/jsf/facelets"
>>        xmlns:composite=3D"http://java.sun.com/jsf/composite"
>>        xmlns:p=3D"http://primefaces.org/ui">
>>=20
>>        <composite:interface>
>>                <composite:attribute name=3D"compId" required=3D"true" =
/>
>>                <composite:attribute name=3D"defaultText" =
required=3D"true" />
>>                <composite:facet name=3D"content" required=3D"false" =
/>
>>        </composite:interface>
>>=20
>>        <composite:implementation>
>>                <span class=3D"buttonlink">
>>                        <composite:renderFacet name=3D"content" />
>>                  </span>
>>        </composite:implementation>
>>=20
>> </html>
>>=20
>>=20
>>=20
>> Then I have a facelet page that uses this composite component and a =
standard
>> <h:commandButton> that invokes an action.
>>=20
>> <!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN"
>> "http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd">
>>=20
>> <html xmlns=3D"http://www.w3.org/1999/xhtml"
>>        xmlns:h=3D"http://java.sun.com/jsf/html"
>>        xmlns:c=3D"http://java.sun.com/jsp/jstl/core"
>>        xmlns:f=3D"http://java.sun.com/jsf/core"
>>        xmlns:ui=3D"http://java.sun.com/jsf/facelets"
>>        xmlns:custom=3D"http://java.sun.com/jsf/composite/components"
>>        xmlns:p=3D"http://primefaces.org/ui"
>>        xmlns:pe=3D"http://primefaces.org/ui/extensions"
>>        lang=3D"en">
>>=20
>> <h:head>
>> </h:head>
>> <h:body>
>>=20
>>        <div class=3D"container">
>>=20
>>                <div class=3D"row">
>>                        <div id=3D"workspace">
>>                                <h:form id=3D"taskListForm" =
prependId=3D"false">
>>                                        <custom:buttonSelectBox
>> compId=3D"myLinksMenu" defaultText=3D"2222">
>>                                                <f:facet =
name=3D"content">
>>                                            <ul>
>>                                                <li><a href=3D"#">My
>> Preferences</a></li>
>>                                        </ul>
>>                                        <ul>
>>                                                <li><a href=3D"#">My
>> Profile</a></li>
>>                                            <li><a
>> =
href=3D"#{facesContext.externalContext.requestContextPath}/logout">Logout<=
/a></li>
>>                                        </ul>
>>                                                </f:facet>
>>                                        </custom:buttonSelectBox>
>>=20
>>                                        <h:commandButton
>> action=3D"#{testBean.buttonAction}" value=3D"Click ME" />
>>                                </h:form>
>>                        </div>
>>                </div>
>>        </div>
>>=20
>> </h:body>
>> </html>
>>=20
>>=20
>> The issue is whenever the web app that contains the above deployed to =
web
>> container (I am using Websphere 7), the button on the facelet page =
does not
>> register the action until the second click, i.e. the first click does
>> nothing. The request did reach the server though.
>>=20
>> I have tried every version since 2.1.4 - 2.1.8, and it still =
occurring - so
>> I am currently downgraded to 2.1.3.
>>=20
>> Can you please advise if this is a bug or something that I have =
missed? If
>> this is a bug, how can I go about raising this in JIRA?
>>=20
>> Any comment would be much appreciated.
>>=20
>> Thanks.
>>=20
>> Regards,
>> Zhao
>>=20
>>=20
>>=20
>>=20
>>=20
>>=20
>>=20