From dev-return-60539-apmail-myfaces-dev-archive=myfaces.apache.org@myfaces.apache.org Thu Dec 20 17:32:52 2012 Return-Path: X-Original-To: apmail-myfaces-dev-archive@www.apache.org Delivered-To: apmail-myfaces-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id B950CDB66 for ; Thu, 20 Dec 2012 17:32:52 +0000 (UTC) Received: (qmail 71520 invoked by uid 500); 20 Dec 2012 17:32:52 -0000 Delivered-To: apmail-myfaces-dev-archive@myfaces.apache.org Received: (qmail 71343 invoked by uid 500); 20 Dec 2012 17:32:52 -0000 Mailing-List: contact dev-help@myfaces.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: "MyFaces Development" Delivered-To: mailing list dev@myfaces.apache.org Received: (qmail 71331 invoked by uid 99); 20 Dec 2012 17:32:52 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 20 Dec 2012 17:32:52 +0000 X-ASF-Spam-Status: No, hits=-0.5 required=5.0 tests=FREEMAIL_ENVFROM_END_DIGIT,RCVD_IN_DNSWL_LOW,SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (nike.apache.org: domain of lu4242@gmail.com designates 209.85.220.49 as permitted sender) Received: from [209.85.220.49] (HELO mail-pa0-f49.google.com) (209.85.220.49) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 20 Dec 2012 17:32:45 +0000 Received: by mail-pa0-f49.google.com with SMTP id bi1so2227608pad.22 for ; Thu, 20 Dec 2012 09:32:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :content-type; bh=tvNl4oBUEBGYiSmeP1X2QdYB9a1ti2hVQC8Als6GIcI=; b=At9ONH6WJCVNT6hjROiQw0PM4MJosFC551h426cb1eXOQIkJPi+qg9ZghsY6UcWo4P vXvd1Daj88K+gkuuRi3BD1l/Wmw0y4KCPwvJWabeNtwb7ye38aS5+JG40vBZR5/hyyg1 QlyQKbwMEWhJ/MeSJ3+6sBIcy0DtCp7ywUqPZ/adYKBu8crg6ZJl3rpLK45tW12v4y1o 3SG2vVw0a3b/m34xI7mFGg4a6M7oQVyb4zmfOvdLYebWCi6YvOoqiTTXKGZgDFfY0UyK vR1AuQOkkByJTWtVy2OVzxcmjOI/mZU0t4weeQoIcD3xHg/Y9p0bLRkwwzKN6W/uovmZ Yj4A== MIME-Version: 1.0 Received: by 10.66.88.198 with SMTP id bi6mr29285062pab.54.1356024744426; Thu, 20 Dec 2012 09:32:24 -0800 (PST) Received: by 10.66.220.41 with HTTP; Thu, 20 Dec 2012 09:32:24 -0800 (PST) In-Reply-To: <60517876-ED01-413E-8228-FF2CBA1674B7@gmail.com> References: <60517876-ED01-413E-8228-FF2CBA1674B7@gmail.com> Date: Thu, 20 Dec 2012 12:32:24 -0500 Message-ID: Subject: Re: MyFaces 2.1.8 - Issues with composite component renderFacet From: Leonardo Uribe To: MyFaces Development Content-Type: text/plain; charset=ISO-8859-1 X-Virus-Checked: Checked by ClamAV on apache.org Hi It is probably a bug, just that it is hard to see it at first view. I can't reproduce it, but I found the change that create the problem: https://issues.apache.org/jira/browse/MYFACES-3373 UIForm.createUniqueId should take into account prependId logic The problem is related to https://issues.apache.org/jira/browse/MYFACES-3663 UIViewRoot.createUniqueId() should generate unique ids for all the component tree. I think in your case there should be one component programatically added by a third party library that changes the order of the generated ids. If the order changes, the action is not executed the first time. I suppose if you set prependId to true it will work. Please reopen MYFACES-3373 in order to fix it properly. I think the solution is only apply the code when prependId is false AND the seed is not provided. Thanks for the report. Issues like this one are hard to find. regards, Leonardo Uribe 2012/12/20 Zhao Koh : > Hi all, > > I am currently using MyFaces 2.1.8 but discovered an issue with composite > component renderFacet - and this issue started at version 2.1.4. > > The following describes the problem: > > I have a composite component called buttonSelectBox that uses > composite:renderFacet to inject content from client - nothing fancy, only a > span that surrounds the content. > > > xmlns:h="http://java.sun.com/jsf/html" > xmlns:f="http://java.sun.com/jsf/core" > xmlns:c="http://java.sun.com/jsp/jstl/core" > xmlns:ui="http://java.sun.com/jsf/facelets" > xmlns:composite="http://java.sun.com/jsf/composite" > xmlns:p="http://primefaces.org/ui"> > > > > > > > > > > > > > > > > > > Then I have a facelet page that uses this composite component and a standard > that invokes an action. > > "http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd"> > > xmlns:h="http://java.sun.com/jsf/html" > xmlns:c="http://java.sun.com/jsp/jstl/core" > xmlns:f="http://java.sun.com/jsf/core" > xmlns:ui="http://java.sun.com/jsf/facelets" > xmlns:custom="http://java.sun.com/jsf/composite/components" > xmlns:p="http://primefaces.org/ui" > xmlns:pe="http://primefaces.org/ui/extensions" > lang="en"> > > > > > >
> >
>
> > compId="myLinksMenu" defaultText="2222"> > > > > > > > action="#{testBean.buttonAction}" value="Click ME" /> > >
>
>
> >
> > > > The issue is whenever the web app that contains the above deployed to web > container (I am using Websphere 7), the button on the facelet page does not > register the action until the second click, i.e. the first click does > nothing. The request did reach the server though. > > I have tried every version since 2.1.4 - 2.1.8, and it still occurring - so > I am currently downgraded to 2.1.3. > > Can you please advise if this is a bug or something that I have missed? If > this is a bug, how can I go about raising this in JIRA? > > Any comment would be much appreciated. > > Thanks. > > Regards, > Zhao > > > > > > >