myfaces-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "dennis hoersch (JIRA)" <...@myfaces.apache.org>
Subject [jira] [Commented] (MYFACES-3659) Conditional include of scripts and stylesheets
Date Thu, 20 Dec 2012 10:49:12 GMT

    [ https://issues.apache.org/jira/browse/MYFACES-3659?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13536935#comment-13536935
] 

dennis hoersch commented on MYFACES-3659:
-----------------------------------------

I think in opposite to mctx.markForDeletion the method mctx.markRelocatableResourceForDeletion()
has to be called in any case because newly created resource components have to be marked as
well. (Or is there a way to recognize if a component is newly build during the current run?)

I attached a new patch with changed
- DefaultFacelet
- ComponentTagHandlerDelegate
- FaceletCompositionContext
- FaceletCompositionContextImpl

---

Thank you for your explanations about the state.

---

Note that the as is HtmlScriptRenderer always sets renderTarget for the 'head' and not the
'real' target, I just saw that comparing my changes here. That might not be the desired behavior.

                
> Conditional include of scripts and stylesheets 
> -----------------------------------------------
>
>                 Key: MYFACES-3659
>                 URL: https://issues.apache.org/jira/browse/MYFACES-3659
>             Project: MyFaces Core
>          Issue Type: Bug
>    Affects Versions: 2.1.6
>         Environment: MyFaces 2.1.6, Tomahawk20 1.1.11
>            Reporter: dennis hoersch
>         Attachments: MYFACES-3659_2.diff, MYFACES-3659_2.zip, patch-MYFACES-3659.diff,
patch-MYFACES-3659.zip
>
>
> I am inserting a script 'X.js' dependent on a condition (c:if). The default case is to
include it. If I change the underlying value within an action so that the condition evaluates
to false, the script is still included. Also after any other following action.
> Using F5 in Firefox the page is now rendered without the script.
> The script 'X.js' was added to the view root and is never 'forgot' or removed. It is
the same if the script is included in a composite component. In that case I even observed
that the order of the scripts changes and the script 'X.js' is included before other basic
scripts like jQuery on which 'X.js' depends.
> ----
> <h:form id="form">
>   <c:set var="sessionScope" value="#{facesContext.externalContext.sessionMap}" />
>     
>   <h:commandButton value="deactivate"
>       rendered="#{empty sessionScope.__isActive_ or sessionScope.__isActive_}">
>       <f:setPropertyActionListener target="#{sessionScope.__isActive_}" value="#{false}"
/>
>   </h:commandButton>
>   <h:commandButton value="activate"
>       rendered="#{not empty sessionScope.__isActive_ and not sessionScope.__isActive_}">
>       <f:setPropertyActionListener target="#{sessionScope.__isActive_}" value="#{true}"
/>
>   </h:commandButton>
>     
>   <h:commandButton value="do nothing" />
>     
>   <h:outputScript library="js" name="jQuery.js" target="body" />
>     
>   <c:if test="#{empty sessionScope.__isActive_ or sessionScope.__isActive_}">
>     BLA
>     <h:outputScript library="js" name="X.js" target="body" />
>     </c:if>      
> </h:form>
> ----
> Am I doing something wrong? Is there another (or better) way to include scripts conditionally?
> (
> If I change 'HtmlOutputScriptHandler' to set the script transient, it works in the first
glance, but I don't know the impact...
> @Override
> public void onComponentPopulated(FaceletContext ctx, UIComponent c, UIComponent parent)
{
>     super.onComponentPopulated(ctx, c, parent);
>     c.setTransient(true);
> }
> )

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message