myfaces-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Leonardo Uribe (JIRA)" <...@myfaces.apache.org>
Subject [jira] [Resolved] (TOMAHAWK-1630) Render conditional comments for IE at the html tag
Date Sun, 07 Oct 2012 05:21:03 GMT

     [ https://issues.apache.org/jira/browse/TOMAHAWK-1630?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Leonardo Uribe resolved TOMAHAWK-1630.
--------------------------------------

       Resolution: Fixed
    Fix Version/s: 1.1.14-SNAPSHOT
         Assignee: Leonardo Uribe

Committed patch, with the new property name changed to includeBrowserSelectors. Thanks to
dennis hoersch for provide this patch.
                
> Render conditional comments for IE at the html tag
> --------------------------------------------------
>
>                 Key: TOMAHAWK-1630
>                 URL: https://issues.apache.org/jira/browse/TOMAHAWK-1630
>             Project: MyFaces Tomahawk
>          Issue Type: Improvement
>    Affects Versions: 1.1.11
>         Environment: MyFaces 2.1.6, Tomahawk20 1.1.11
>            Reporter: dennis hoersch
>            Assignee: Leonardo Uribe
>             Fix For: 1.1.14-SNAPSHOT
>
>         Attachments: Document.java, DocumentRenderer.java, patch_DocumentRenderer.txt,
patch_Document.txt
>
>
> Hi,
> in our old (pre-JSF2) product version we use some IE conditional comments to insert IE
specific stylesheets:
> <h:outputText
>   value="&lt;!--[if IE 9]&gt;&lt;link rel=&quot;stylesheet&quot;
type=&quot;text/css&quot; href=&quot;/path/to/someIE9.css&quot;/&gt;&lt;![endif]--&gt;"
>   escape="false" />
> But now I want to use <h:outputStylesheet />. (So that the stylesheets are registered
at the view root.)
> My researches in the Internet gave me a solution used by other frameworks: surround the
HTML root tag with conditional comments an give them IE version specific classes:
> <!--[if lt IE 7 ]><html xmlns="http://www.w3.org/1999/xhtml" lang="de" class="ie
ie6"><![endif]-->
> <!--[if IE 7 ]><html xmlns="http://www.w3.org/1999/xhtml" lang="de" class="ie
ie7"><![endif]-->
> <!--[if IE 8 ]><html xmlns="http://www.w3.org/1999/xhtml" lang="de" class="ie
ie8"><![endif]-->
> <!--[if IE 9 ]><html xmlns="http://www.w3.org/1999/xhtml" lang="de" class="ie
ie9"><![endif]-->
> <!--[if (gt IE 9)|!(IE)]><!--><html xmlns="http://www.w3.org/1999/xhtml"
lang="de"><!--<![endif]-->
> so we can have style definitions like:
> .ie8 .someOtherClass {...}
> I attached a patch of the Document to support an attribute which causes the DocumentRenderer
to render these conditional comments on the HTML root tag.
> May it be reasonable to Tomahawk to support this? 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message