myfaces-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Leonardo Uribe (JIRA)" <...@myfaces.apache.org>
Subject [jira] [Commented] (MYFACES-3587) Not existing viewId will not be handled
Date Wed, 29 Aug 2012 03:35:07 GMT

    [ https://issues.apache.org/jira/browse/MYFACES-3587?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13443781#comment-13443781
] 

Leonardo Uribe commented on MYFACES-3587:
-----------------------------------------

There is no null check by backward behavior. Add it cause problems with some compatibility
tests. So, we cannot change the code in MyFaces, but it is valid to add the check in your
project and there should not be any side effect. I'll close this issue as won't fix.
                
> Not existing viewId will not be handled
> ---------------------------------------
>
>                 Key: MYFACES-3587
>                 URL: https://issues.apache.org/jira/browse/MYFACES-3587
>             Project: MyFaces Core
>          Issue Type: Bug
>          Components: General
>    Affects Versions: 2.1.8
>         Environment: Jetty/Tomcat, JUEL, CODI, ExtVal
>            Reporter: Thomas Andraschko
>
> If i call a page, which does not exist, following exceptions occurs: Cannot reset buffer
after response has been committed.
> After digging deeper into this problem, i found out that getViewHandlerSupport()#calculateViewId
returns null and the JspViewDeclarationLanguageStrategy will be used -> 
> Cannot reset buffer after response has been committed. 
> occurs.
> I added a null check for the logicalViewId in RestoreViewExecutor#execute to call HttpServletResponse#sendError.
> It does not work as expected because it just renders the errorPage and no redirect will
be done.
> Why there is not such null check?
> Is it possible to add this check and redirect to the web.xml defined 404 or common error
page? Or should it use the ErrorHandler?

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message