Mailing-List: contact dev-help@myfaces.apache.org; run by ezmlm
Precedence: bulk
Reply-To: "MyFaces Development" <dev@myfaces.apache.org>
Date: Wed, 11 Jul 2012 13:02:35 +0000 (UTC)
From: "Mark Struberg (JIRA)" <dev@myfaces.apache.org>
To: dev@myfaces.apache.org
Message-ID: <61014810.34991.1342011755086.JavaMail.jiratomcat@issues-vm>
In-Reply-To: <1843801179.34686.1342004614783.JavaMail.jiratomcat@issues-vm>
Subject: [jira] [Commented] (EXTCDI-298) [perf] reduce overhead in
 ClassUtils
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/EXTCDI-298?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13411454#comment-13411454 ] 

Mark Struberg commented on EXTCDI-298:
--------------------------------------

Can you please test now? I've at least removed the doPrivileged for you. It will now only get executed if a SecurityManager is present.

For fixing the loadClassForName I would need a stacktrace. And the number of times this gets called.

A cache as you did it is not possible since "org.mypackage.MyClass" might be different for WebAppA and a WebAppB...
                
> [perf] reduce overhead in ClassUtils
> ------------------------------------
>
>                 Key: EXTCDI-298
>                 URL: https://issues.apache.org/jira/browse/EXTCDI-298
>             Project: MyFaces CODI
>          Issue Type: Improvement
>            Reporter: Thomas Andraschko
>            Assignee: Mark Struberg
>         Attachments: EXTCDI-298.patch
>
>
> As discussed with gerhard, i removed the #doPriviliged which improved the method execution duration from 50ms to 0ms (30.000 invocations / request)
> I also added a class cache which improves loadClassForName from 62ms to 6ms for 9600 invocations.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira