myfaces-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Neil Griffin (JIRA)" <...@myfaces.apache.org>
Subject [jira] [Commented] (PORTLETBRIDGE-226) requestProcessingNonFacesTest specifies charset in JSP
Date Thu, 26 Jul 2012 17:31:34 GMT

    [ https://issues.apache.org/jira/browse/PORTLETBRIDGE-226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13423264#comment-13423264
] 

Neil Griffin commented on PORTLETBRIDGE-226:
--------------------------------------------

Here is the patch by Mike Freedman:

Change the following line (line 51) in chapter4_2_5Result.jsp:

Existing:
if (contentType.equals(renderRequest.getResponseContentType()) && dispatcherPass)

New:
if (contentType.startsWith(renderRequest.getResponseContentType()) && dispatcherPass)

                
> requestProcessingNonFacesTest specifies charset in JSP
> ------------------------------------------------------
>
>                 Key: PORTLETBRIDGE-226
>                 URL: https://issues.apache.org/jira/browse/PORTLETBRIDGE-226
>             Project: MyFaces Portlet Bridge
>          Issue Type: TCK Challenge
>          Components: TCK
>    Affects Versions: 2.0.0
>         Environment: Liferay Portal + Liferay Faces Bridge
>            Reporter: Neil Griffin
>            Assignee: Michael Freedman
>
> [Test Challenger Name and Company] 
> Neil Griffin, Liferay, Inc. 
> [Specification Name(s) and Version(s)] 
> Portlet 2.0 Bridge for JavaServerâ„¢ Faces 1.2 
> [Test Suite Name and Version] 
> portlet-bridge-tck-main, v1.0.0 
> [Exclude List Version] 
> N/A 
> [Test Name] 
> requestProcessingNonFacesTest
> [Complaint (argument for why test is invalid)] 
> If the TestPage017 (requestProcessingNonFacesTest) is successful, the output text should
be the following:
> {code}Detail: Expected response content type is text/html, actual value is text/html.{code}
> However, under Liferay Portal the test fails with the following:
> {code}Detail: Expected response content type is text/html, actual value is text/html;
charset=UTF-8.{code}
> The reason why is because the test contains a JSP file named chapter4_2_5Result.jsp that
starts with the following directive:
> <%@ page contentType = "text/html; charset=UTF-8" ... %>
> ... and Liferay Portal has a feature that respects the contentType attribute of the page
directive, which ultimately calls back into the Liferay implementation of [MimeResponse.setContentType(String)|http://portals.apache.org/pluto/portlet-2.0-apidocs/javax/portlet/MimeResponse.html#setContentType(java.lang.String)].
That's why Liferay returns an actual value of "text/html; charset=UTF-8"

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

Mime
View raw message