Return-Path: X-Original-To: apmail-myfaces-dev-archive@www.apache.org Delivered-To: apmail-myfaces-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 9EEB9D777 for ; Fri, 29 Jun 2012 13:21:45 +0000 (UTC) Received: (qmail 75372 invoked by uid 500); 29 Jun 2012 13:21:45 -0000 Delivered-To: apmail-myfaces-dev-archive@myfaces.apache.org Received: (qmail 75308 invoked by uid 500); 29 Jun 2012 13:21:45 -0000 Mailing-List: contact dev-help@myfaces.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: "MyFaces Development" Delivered-To: mailing list dev@myfaces.apache.org Received: (qmail 75189 invoked by uid 99); 29 Jun 2012 13:21:45 -0000 Received: from issues-vm.apache.org (HELO issues-vm) (140.211.11.160) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 29 Jun 2012 13:21:45 +0000 Received: from isssues-vm.apache.org (localhost [127.0.0.1]) by issues-vm (Postfix) with ESMTP id 33696142849 for ; Fri, 29 Jun 2012 13:21:44 +0000 (UTC) Date: Fri, 29 Jun 2012 13:21:44 +0000 (UTC) From: "Leonardo Uribe (JIRA)" To: dev@myfaces.apache.org Message-ID: <931275599.71499.1340976104212.JavaMail.jiratomcat@issues-vm> In-Reply-To: <1515025073.71047.1340964464639.JavaMail.jiratomcat@issues-vm> Subject: [jira] [Commented] (TOMAHAWK-1630) Render conditional comments for IE at the html tag MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/TOMAHAWK-1630?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13403888#comment-13403888 ] Leonardo Uribe commented on TOMAHAWK-1630: ------------------------------------------ I think it is a very useful feature. I would like to find a better name for renderConditionalCommentsAndStyleClasses . Maybe includeBrowserSelectors ? It could be more meaningful. > Render conditional comments for IE at the html tag > -------------------------------------------------- > > Key: TOMAHAWK-1630 > URL: https://issues.apache.org/jira/browse/TOMAHAWK-1630 > Project: MyFaces Tomahawk > Issue Type: Improvement > Affects Versions: 1.1.11 > Environment: MyFaces 2.1.6, Tomahawk20 1.1.11 > Reporter: dennis hoersch > Attachments: Document.java, DocumentRenderer.java, patch_Document.txt, patch_DocumentRenderer.txt > > > Hi, > in our old (pre-JSF2) product version we use some IE conditional comments to insert IE specific stylesheets: > value="" > escape="false" /> > But now I want to use . (So that the stylesheets are registered at the view root.) > My researches in the Internet gave me a solution used by other frameworks: surround the HTML root tag with conditional comments an give them IE version specific classes: > > > > > > so we can have style definitions like: > .ie8 .someOtherClass {...} > I attached a patch of the Document to support an attribute which causes the DocumentRenderer to render these conditional comments on the HTML root tag. > May it be reasonable to Tomahawk to support this? -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira