myfaces-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Leonardo Uribe (JIRA)" <...@myfaces.apache.org>
Subject [jira] [Commented] (MYFACES-3575) Disable relative location caching in DefaultFaceletFactory
Date Thu, 28 Jun 2012 15:28:43 GMT

    [ https://issues.apache.org/jira/browse/MYFACES-3575?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13403164#comment-13403164
] 

Leonardo Uribe commented on MYFACES-3575:
-----------------------------------------

I have been thinking about this problem and the intention of _relativeLocations is prevent
unnecessary calls to ExternalContext.getResource(). In theory a cache like this one should
be inside ResourceResolver implementation, because that's the right location to do that caching.
Also, that part is done there to prevent unnecessary URL parsing.

The real problem is the whole hack proposed violates Partial State Saving (PSS) requeriments,
because it allows to change the location of the templates for a given string pointing to a
template. So, if there is a postback and something has changed the algorithm will fail.




                
> Disable relative location caching in DefaultFaceletFactory
> ----------------------------------------------------------
>
>                 Key: MYFACES-3575
>                 URL: https://issues.apache.org/jira/browse/MYFACES-3575
>             Project: MyFaces Core
>          Issue Type: Improvement
>          Components: Extension Feature
>    Affects Versions: 2.0.14, 2.1.8
>         Environment: Linux
>            Reporter: Dmitry Kukushkin
>            Assignee: Leonardo Uribe
>            Priority: Minor
>
> In some circumstances the caching of the relative location in the public Facelet getFacelet(String
uri) in DefaultFaceletFactory is not desirable: e.g. return the mobile and full content version
for the same URI, if the user changes the content type on the fly. Now this caching always
causes the same content to be returned.
> Should it be possible to switch it off like it is done for other caches in this class
with needsToBeRefreshed check and NO_CACHE_DELAY configuration parameter?

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message