Mailing-List: contact dev-help@myfaces.apache.org; run by ezmlm
Precedence: bulk
Reply-To: "MyFaces Development" <dev@myfaces.apache.org>
Date: Fri, 25 May 2012 15:06:23 +0000 (UTC)
From: "Leonardo Uribe (JIRA)" <dev@myfaces.apache.org>
To: dev@myfaces.apache.org
Message-ID: <1001343202.2511.1337958383455.JavaMail.jiratomcat@issues-vm>
In-Reply-To: <2053222227.9382.1337717500870.JavaMail.jiratomcat@issues-vm>
Subject: [jira] [Commented] (MYFACES-3552) [perf] pps: reduce amout of
 Object [] created in _DeltaList.saveState
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable


    [ https://issues.apache.org/jira/browse/MYFACES-3552?page=3Dcom.atlassi=
an.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D13=
283514#comment-13283514 ]=20

Leonardo Uribe commented on MYFACES-3552:
-----------------------------------------

The patch has a bug, it remove one line that sets nullDelta =3D false , whi=
ch is used later to check if it should return null or not. I think it is be=
tter to let is as is, because the jvm is smart enough to quickly gc the ins=
tance created if it does not used, because it is discarded inside the same =
method.=20
               =20
> [perf] pps: reduce amout of Object [] created in _DeltaList.saveState
> ---------------------------------------------------------------------
>
>                 Key: MYFACES-3552
>                 URL: https://issues.apache.org/jira/browse/MYFACES-3552
>             Project: MyFaces Core
>          Issue Type: Improvement
>            Reporter: Martin Ko=C4=8D=C3=AD
>            Priority: Minor
>         Attachments: MYFACES-3552-v1.patch
>
>
> consider a component with 5 listeners (or other attached objects). All li=
steners implement PartialStateHolder.
> In a ideal case, delta is 0.
> javax.faces.component._DeltaList.saveState(FacesContext) currently create=
s :
> 1) a Object [] array with length 5
> 2) a  _AttachedDeltaWrapper, one for each listener, 5 total
> but in the end, when delta is 0, saveState returns null and all object ar=
e GCed immediately

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrato=
rs: https://issues.apache.org/jira/secure/ContactAdministrators!default.jsp=
a
For more information on JIRA, see: http://www.atlassian.com/software/jira