myfaces-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Leonardo Uribe (JIRA)" <...@myfaces.apache.org>
Subject [jira] [Commented] (MYFACES-3552) [perf] pps: reduce amout of Object [] created in _DeltaList.saveState
Date Fri, 25 May 2012 15:06:23 GMT

    [ https://issues.apache.org/jira/browse/MYFACES-3552?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13283514#comment-13283514
] 

Leonardo Uribe commented on MYFACES-3552:
-----------------------------------------

The patch has a bug, it remove one line that sets nullDelta = false , which is used later
to check if it should return null or not. I think it is better to let is as is, because the
jvm is smart enough to quickly gc the instance created if it does not used, because it is
discarded inside the same method. 
                
> [perf] pps: reduce amout of Object [] created in _DeltaList.saveState
> ---------------------------------------------------------------------
>
>                 Key: MYFACES-3552
>                 URL: https://issues.apache.org/jira/browse/MYFACES-3552
>             Project: MyFaces Core
>          Issue Type: Improvement
>            Reporter: Martin Kočí
>            Priority: Minor
>         Attachments: MYFACES-3552-v1.patch
>
>
> consider a component with 5 listeners (or other attached objects). All listeners implement
PartialStateHolder.
> In a ideal case, delta is 0.
> javax.faces.component._DeltaList.saveState(FacesContext) currently creates :
> 1) a Object [] array with length 5
> 2) a  _AttachedDeltaWrapper, one for each listener, 5 total
> but in the end, when delta is 0, saveState returns null and all object are GCed immediately

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

Mime
View raw message