myfaces-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Leonardo Uribe (Resolved) (JIRA)" <...@myfaces.apache.org>
Subject [jira] [Resolved] (TOMAHAWK-1609) tomahawk12 <t:htmlTag tag="br"/> generates <br></br> which many browsers parse as two break tags when parsing as HTML.
Date Tue, 17 Apr 2012 23:04:19 GMT

     [ https://issues.apache.org/jira/browse/TOMAHAWK-1609?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Leonardo Uribe resolved TOMAHAWK-1609.
--------------------------------------

       Resolution: Fixed
    Fix Version/s: 1.1.12-SNAPSHOT
         Assignee: Leonardo Uribe

I checked it and there is a bad line that force ends all tags, but that is responsibility
of the ResponseWriter provided by the Renderkit. I believe the code was added by some issue
related to jsp long time ago. The right thing to do is remove that line and let ResponseWriter
to close it properly or not. I can't found the svn revision this one was introduced, maybe
when tomahawk core12 module was open. Anyway, I commented the line and added a comment.
                
> tomahawk12 <t:htmlTag tag="br"/> generates <br></br> which many browsers
parse as two break tags when parsing as HTML.
> ----------------------------------------------------------------------------------------------------------------------
>
>                 Key: TOMAHAWK-1609
>                 URL: https://issues.apache.org/jira/browse/TOMAHAWK-1609
>             Project: MyFaces Tomahawk
>          Issue Type: Bug
>          Components: Html Tag
>    Affects Versions: 1.1.8, 1.1.11
>         Environment: WebSphere 7.0.x using Firefox 9, IE 8 and 9, and Chrome
>            Reporter: Bob Mitchell
>            Assignee: Leonardo Uribe
>             Fix For: 1.1.12-SNAPSHOT
>
>
> In the tomahawk12 library htmlTag forces tags specified by the "tag"attribute to have
separate start and end tags.  However HTML specifically disallows certain tags, like 'br'
having end tags.  Many browsers parse the end 'br' tag as a second tag, rather than an end
to the first tag.
> Note that the tomahawk (JSF 1.1 version) library does not do this.  It has a different
implementation of the HtmlTagRenderer.encodeEnd method.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message