myfaces-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Leonardo Uribe (Updated) (JIRA)" <...@myfaces.apache.org>
Subject [jira] [Updated] (MYFACES-3473) [perf] Avoid unnecessary _ComponentChildrenList instances - improve HtmlRenderer.getChildren
Date Wed, 07 Mar 2012 20:46:58 GMT

     [ https://issues.apache.org/jira/browse/MYFACES-3473?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Leonardo Uribe updated MYFACES-3473:
------------------------------------

       Resolution: Fixed
    Fix Version/s: 2.1.7
                   2.0.13
         Assignee: Leonardo Uribe  (was: Martin Kočí)
           Status: Resolved  (was: Patch Available)

The change proposed breaks the original intention of the code. Instead, it is more easier
to check in all locations if the child count is > 0 and if that so, call getChildren.
                
> [perf] Avoid unnecessary _ComponentChildrenList instances - improve HtmlRenderer.getChildren
> --------------------------------------------------------------------------------------------
>
>                 Key: MYFACES-3473
>                 URL: https://issues.apache.org/jira/browse/MYFACES-3473
>             Project: MyFaces Core
>          Issue Type: Improvement
>            Reporter: Martin Kočí
>            Assignee: Leonardo Uribe
>            Priority: Trivial
>             Fix For: 2.0.13, 2.1.7
>
>         Attachments: MYFACES-3473.patch
>
>
> HtmlRenderer.getChildren calls component.getChildren() directly and initializes _ComponentChildrenList
instance even if component has no children.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

Mime
View raw message