myfaces-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Leonardo Uribe (Updated) (JIRA)" <...@myfaces.apache.org>
Subject [jira] [Updated] (MYFACES-3448) UISelectOne.validateValue(...) optimised & refactored
Date Fri, 02 Mar 2012 19:15:58 GMT

     [ https://issues.apache.org/jira/browse/MYFACES-3448?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Leonardo Uribe updated MYFACES-3448:
------------------------------------

       Resolution: Fixed
    Fix Version/s: 2.1.7
                   2.0.13
         Assignee: Leonardo Uribe
           Status: Resolved  (was: Patch Available)

Thanks to David Law for provide this patch
                
> UISelectOne.validateValue(...) optimised & refactored
> -----------------------------------------------------
>
>                 Key: MYFACES-3448
>                 URL: https://issues.apache.org/jira/browse/MYFACES-3448
>             Project: MyFaces Core
>          Issue Type: Improvement
>          Components: General
>    Affects Versions: 2.1.5
>            Reporter: David Law
>            Assignee: Leonardo Uribe
>            Priority: Minor
>             Fix For: 2.0.13, 2.1.7
>
>         Attachments: UISelectOne.validateValue.Patch.diff
>
>   Original Estimate: 0h
>  Remaining Estimate: 0h
>
> The UISelectOne.validateValue(...) code is not particularly human-readable to say the
least.
> Also, in the case of a match(the norm) the method this.isRequired() is called twice(!)
if it returns false.
> Patch attached. (100% tested for all permutations of match, isRequired & NoSelection)

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message