Mailing-List: contact dev-help@myfaces.apache.org; run by ezmlm
Precedence: bulk
Reply-To: "MyFaces Development" <dev@myfaces.apache.org>
Received-SPF: pass (nike.apache.org: domain of andrew.rw.robinson@gmail.com
 designates 209.85.210.181 as permitted sender)
Received-SPF: pass (google.com: domain of andrew.rw.robinson@gmail.com
 designates 10.50.15.132 as permitted sender) client-ip=10.50.15.132;
MIME-Version: 1.0
In-Reply-To: <1330096669.77345.YahooMailNeo@web171508.mail.ir2.yahoo.com>
References: <4F447AB5.7070701@gmail.com>
	<091F40BC-CED3-4CA8-A815-ACE4A58E7E24@gmail.com>
	<1330006008.53975.YahooMailNeo@web171509.mail.ir2.yahoo.com>
	<-3419650171701587462@unknownmsgid>
	<1330090378.48037.YahooMailNeo@web171514.mail.ir2.yahoo.com>
	<-3133545986962705105@unknownmsgid>
	<4F47A386.4060401@gmail.com>
	<1330096669.77345.YahooMailNeo@web171508.mail.ir2.yahoo.com>
Date: Mon, 27 Feb 2012 10:44:24 -0700
Message-ID: 
 <CAMwvS1GqS=Oo04dP7x6+C6aSot3j=asq-ASe6X0KNO--xoTygQ@mail.gmail.com>
Subject: Re: [VOTE] Release of Trinidad 2.0.1
From: Andrew Robinson <andrew.rw.robinson@gmail.com>
To: MyFaces Development <dev@myfaces.apache.org>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable

+1

On Fri, Feb 24, 2012 at 8:17 AM, Mark Struberg <struberg@yahoo.de> wrote:
> Hi Scott!
>
> While checking the release I also scanned the other stuff and the rest lo=
oks good.
>
> sorry for the inconvenience...
>
>
> LieGrue,
> strub
>
>
>
> ----- Original Message -----
>> From: Scott O'Bryan <darkarena@gmail.com>
>> To: MyFaces Development <dev@myfaces.apache.org>
>> Cc:
>> Sent: Friday, February 24, 2012 3:49 PM
>> Subject: Re: [VOTE] Release of Trinidad 2.0.1
>>
>> I stand corrected, it IS in there.=A0 :D=A0 We've had those repos in the=
re
>> forever.=A0 Anyway, thanks Mark.
>>
>> So I've checked in the changes you requested to the latest tag and set
>> up the rat audit tool to run as part of the standard build so we don't
>> hit this issue again.=A0 Can you do me a favor and check the tag to make
>> sure it looks good and then I'll promote it to the repository and start
>> over the vote.
>>
>> Thanks,
>> =A0 Scott
>>
>> On Fri 24 Feb 2012 06:56:50 AM MST, Scott O'Bryan wrote:
>>> =A0I'm not sure I agree with this.=A0 In the case of java.net, removing=
 the
>>> =A0invalid repo is a fair assessment, but I'm unaware of any rules in
>>> =A0maven-central that says build artifacts cannot be pulled in from oth=
er
>>> =A0repositories.=A0 Am I missing something here?
>>>
>>> =A0That said, I didn't have time yesterday to investigate the problem.
>>> =A0It might just be a simple Geronimo dep issue.=A0 I have a few mins t=
o
>>> =A0look at this.=A0 Hopefully it's not a difficult problem.
>>>
>>> =A0Sent from my iPhone
>>>
>>> =A0On Feb 24, 2012, at 6:33 AM, Mark Struberg<struberg@yahoo.de>=A0 wro=
te:
>>>
>>>> =A0Hi Scott!
>>>>
>>>>> =A0As for the repositories, I removed them and now seem to be getting
>> an
>>>>> =A0error during testing.
>>>>
>>>>
>>>> =A0Well, doesn't that mean that the source repository doesn't
>> properly build?
>>>>
>>>> =A0Also, such artifacts should not get propagated to maven.central as =
per
>> it's policies.
>>>>
>>>>
>>>> =A0If you need help with the repo stuff then please ping me on IRC and
>> I'll help.
>>>>
>>>>
>>>> =A0LieGrue,
>>>> =A0strub
>>>>
>>>>
>>>>
>>>> =A0----- Original Message -----
>>>>> =A0From: Scott O'Bryan<darkarena@gmail.com>
>>>>> =A0To: MyFaces Development<dev@myfaces.apache.org>
>>>>> =A0Cc:
>>>>> =A0Sent: Friday, February 24, 2012 2:07 PM
>>>>> =A0Subject: Re: [VOTE] Release of Trinidad 2.0.1
>>>>>
>>>>> =A0Okay Marc, I fixed rat and the few license headers we have.=A0 It
>> will
>>>>> =A0now also run automagically as part of the Trinidad build so we can
>>>>> =A0catch these sooner.
>>>>>
>>>>> =A0As for the repositories, I removed them and now seem to be getting
>> an
>>>>> =A0error during testing.=A0 I guess my question is this, since we
>> don't
>>>>> =A0distribute any jboss code with the product, is the repository issu=
e
>>>>> =A0still a blocker or can it be handled as a bug next release?
>>>>>
>>>>> =A0Scott
>>>>>
>>>>> =A0Sent from my iPhone
>>>>>
>>>>> =A0On Feb 23, 2012, at 7:07 AM, Mark
>> Struberg<struberg@yahoo.de>=A0 wrote:
>>>>>
>>>>>> =A0Hi!
>>>>>>
>>>>>> =A0I'm really sorry, but I fear I have to cast a
>>>>>>
>>>>>> =A0-1 :(
>>>>>>
>>>>>>
>>>>>>
>>>>>> =A0A few smallish but imo important things which I found during
>> the review:
>>>>>>
>>>>>> =A01.)
>>>>>>
>>>>>> =A0 =A0 =A0<repositories>
>>>>>> =A0 =A0 =A0 =A0<!-- needed for Bean Validation API -->
>>>>>> =A0 =A0 =A0 =A0<repository>
>>>>>> =A0 =A0 =A0 =A0 =A0<id>jboss</id>
>>>>>> =A0 =A0 =A0 =A0 =A0<name>jboss nexus</name>
>>>>>>
>>>>>
>> <url>http://repository.jboss.org/nexus/content/groups/public-jboss/</url=
>
>>>>>> =A0 =A0 =A0 =A0</repository>
>>>>>>
>>>>>> =A0 =A0 =A0 =A0<!-- Needed for Mojarra -->
>>>>>> =A0 =A0 =A0 =A0<repository>
>>>>>> =A0 =A0 =A0 =A0 =A0<id>maven2-repository.dev.java.net</id>
>>>>>> =A0 =A0 =A0 =A0 =A0<name>Java.net Repository for Maven</name>
>>>>>>
>> <url>http://download.java.net/maven/2/</url>
>>>>>> =A0 =A0 =A0 =A0</repository>
>>>>>> =A0 =A0 =A0</repositories>
>>>>>>
>>>>>> =A0is this really needed?
>>>>>> =A0please the geronimo-spec jar for JSR-303 and Apache BVal
>> instead.
>>>>>>
>>>>>> =A0the java.net repo is btw dead already... All mojarra artifacts
>> are
>>>>> =A0available on maven.central
>>>>>>
>>>>>> =A0Artifacts with a dead repo in it should definitely not get
>> propagated to
>>>>> =A0maven.central!
>>>>>>
>>>>>>
>>>>>> =A02.) please run mvn apache-rat:check
>>>>>>
>>>>>> =A0The following files misses an ALv2 header:
>>>>>>
>>>>>>
>>>>>>
>> trinidad-build/src/main/resources/META-INF/maven-faces-plugin/Global.xml
>>>>>>
>> trinidad-api/src/main/conf/META-INF/myfaces-core-2_0-metadata.xml
>>>>>>
>>>>>>
>>>>>
>> trinidad-impl/src/test/resources/org/apache/myfaces/trinidadinternal/ren=
derkit/testScripts/
>>>>>> =A0contains a lot of stuff, but this should get excluded as they
>> are only test
>>>>> =A0resources.
>>>>>>
>>>>>> =A0Please add the apache-rat plugin to the build and fix the
>> missing headers
>>>>> =A0or tweak the excludes until the build runs fine.
>>>>>>
>>>>>> =A0LieGrue,
>>>>>> =A0strub
>>>>>>
>>>>>>
>>>>>>
>>>>>> =A0----- Original Message -----
>>>>>>> =A0From: Andy Schwartz<andy.g.schwartz@gmail.com>
>>>>>>> =A0To: MyFaces Development<dev@myfaces.apache.org>
>>>>>>> =A0Cc:
>>>>>>> =A0Sent: Thursday, February 23, 2012 1:31 PM
>>>>>>> =A0Subject: Re: [VOTE] Release of Trinidad 2.0.1
>>>>>>>
>>>>>>> =A0+1
>>>>>>>
>>>>>>> =A0Andy
>>>>>>>
>>>>>>> =A0On Feb 22, 2012, at 12:18 AM, Scott O'Bryan
>>>>> =A0<darkarena@gmail.com>
>>>>>>> =A0wrote:
>>>>>>>
>>>>>>>> =A0Hi Everyone,
>>>>>>>>
>>>>>>>> =A0I was running the tasks needed to get the Trinidad
>> 2.0.1 release
>>>>> =A0out and
>>>>>>> =A0now I need a vote as to whether everything looks good or
>> not.=A0 I have
>>>>> =A0committed
>>>>>>> =A0most of the most recent submitted patches and things look
>> to be fairly
>>>>> =A0stable.
>>>>>>> =A0There are a few patches outstanding, but I wanted to put
>> those into
>>>>> =A0trunk so
>>>>>>> =A0that they can get some more testing.
>>>>>>>>
>>>>>>>> =A0This is a very big release with many bug fixes and
>> quite a few
>>>>> =A0fixes to
>>>>>>> =A0support the MyFaces checkstyle audits.=A0 You will notice the
>> absence of
>>>>> =A0the
>>>>>>> =A0"component showcase" example module.=A0 It was
>> decided to
>>>>> =A0remove this
>>>>>>> =A0module because it contains code brought in by Maven which
>> is NOT under
>>>>> =A0the
>>>>>>> =A0Apache license.=A0 The component showcase *IS* available by
>> building the
>>>>> =A0source
>>>>>>> =A0manually.
>>>>>>>>
>>>>>>>> =A0At this time, I would like to ask for a vote on this
>> release.=A0 All
>>>>> =A0of the
>>>>>>> =A0following should be ready for review:
>>>>>>>>
>>>>>>>> =A0* The generated repository and assembly artifacts [1]
>>>>>>>> =A0* The generated source archive [2]
>>>>>>>> =A0* The updated svn repository [3]
>>>>>>>>
>>>>>>>> =A0Please review the artifacts and vote according to the
>> following:
>>>>>>>>
>>>>>>>> =A0------------------------------------------------
>>>>>>>> =A0[ ] +1 for community members who have reviewed the bits
>>>>>>>> =A0[ ] +0
>>>>>>>> =A0[ ] -1 for fatal flaws that should cause these bits not
>> to be
>>>>> =A0released,
>>>>>>>> =A0and why..............
>>>>>>>> =A0------------------------------------------------
>>>>>>>>
>>>>>>>> =A0This vote will remain open for at least 72 hours.
>>>>>>>>
>>>>>>>> =A0Thanks,
>>>>>>>> =A0 =A0 =A0Scott O'Bryan
>>>>>>>>
>>>>>>>> =A0[1]
>>>>>>>
>>>>>
>> https://repository.apache.org/content/repositories/orgapachemyfaces-005/
>>>>>>>> =A0[2]
>>>>>>>
>>>>>
>> https://repository.apache.org/content/repositories/orgapachemyfaces-005/=
org/apache/myfaces/trinidad/trinidad/2.0.1/trinidad-2.0.1-source-release.zi=
p
>>>>>>>> =A0[3]
>>>>>
>> https://svn.apache.org/repos/asf/myfaces/trinidad/tags/trinidad-2.0.1/
>>>>>>>>
>>>>>>>
>>>>>
>>