Mailing-List: contact dev-help@myfaces.apache.org; run by ezmlm
Precedence: bulk
Reply-To: "MyFaces Development" <dev@myfaces.apache.org>
Date: Mon, 27 Feb 2012 03:51:50 +0000 (UTC)
From: "Leonardo Uribe (Resolved) (JIRA)" <dev@myfaces.apache.org>
To: dev@myfaces.apache.org
Message-ID: 
 <2113884016.22022.1330314710318.JavaMail.tomcat@hel.zones.apache.org>
In-Reply-To: 
 <656191378.21148.1330275173238.JavaMail.tomcat@hel.zones.apache.org>
Subject: [jira] [Resolved] (MYFACES-3481) [perf] f:validateBean re-creates
 facelets handlers (MetaRulesetImpl,DelegatingMetaTagHandler ...) for
 children every time
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable


     [ https://issues.apache.org/jira/browse/MYFACES-3481?page=3Dcom.atlass=
ian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Leonardo Uribe resolved MYFACES-3481.
-------------------------------------

       Resolution: Fixed
    Fix Version/s: 2.1.7
                   2.0.13
         Assignee: Leonardo Uribe
   =20
> [perf] f:validateBean re-creates facelets handlers (MetaRulesetImpl,Deleg=
atingMetaTagHandler ...) for children every time
> -------------------------------------------------------------------------=
------------------------------------------------
>
>                 Key: MYFACES-3481
>                 URL: https://issues.apache.org/jira/browse/MYFACES-3481
>             Project: MyFaces Core
>          Issue Type: Improvement
>            Reporter: Martin Ko=C4=8D=C3=AD
>            Assignee: Leonardo Uribe
>             Fix For: 2.0.13, 2.1.7
>
>
> myfaces in Production stage:
> <f:validateBean>
>             <h:outputLabel>myfaces</h:outputLabel>
> </f:validateBean>
> (or book.xhtml in myfaces-jpa test app)
> In every request/response, this invocation appears:
> MetaRulesetImpl.<init>(Tag, Class<?>) line: 118=09
> ComponentTagHandlerDelegate.createMetaRuleset(Class) line: 459=09
> HtmlComponentHandler(DelegatingMetaTagHandler).createMetaRuleset(Class) l=
ine: 102=09
> HtmlComponentHandler.createMetaRuleset(Class) line: 42=09
> HtmlComponentHandler(MetaTagHandler).setAttributes(FaceletContext, Object=
) line: 63=09
> HtmlComponentHandler(DelegatingMetaTagHandler).setAttributes(FaceletConte=
xt, Object) line: 93=09
> ComponentTagHandlerDelegate.apply(FaceletContext, UIComponent) line: 235=
=09
> HtmlComponentHandler(DelegatingMetaTagHandler).apply(FaceletContext, UICo=
mponent) line: 53=09
> ValidatorTagHandlerDelegate.apply(FaceletContext, UIComponent) line: 152=
=09
> ValidatorHandler(DelegatingMetaTagHandler).apply(FaceletContext, UICompon=
ent) line: 53=09
> this applies for all children of f:validateBean
> Without f:validateBean Metatag rules are created only once in production =
stage during initial request to facelet.
> (Not sure if it is a bug - maybe something special needs to be done for f=
:beanValidator )
> It also leads to stack bellow - but _getFactory method is synchronized an=
d slow down response times to  the same facelet:
> FactoryFinder._getFactory(String) line: 259=09
> FactoryFinder.getFactory(String) line: 206=09
> ConvertNumberHandler(DelegatingMetaTagHandler).<init>(TagConfig) line: 42=
=09
> ConvertNumberHandler(FaceletsAttachedObjectHandler).<init>(TagConfig) lin=
e: 42=09
> ConvertNumberHandler(ConverterHandler).<init>(ConverterConfig) line: 44=
=09
> ConvertNumberHandler.<init>(ConverterConfig) line: 57=09
> NativeConstructorAccessorImpl.newInstance0(Constructor, Object[]) line: n=
ot available [native method]=09
> NativeConstructorAccessorImpl.newInstance(Object[]) line: 39=09
> DelegatingConstructorAccessorImpl.newInstance(Object[]) line: 27=09
> Constructor<T>.newInstance(Object...) line: 513=09
> AbstractTagLibrary$UserConverterHandlerFactory.createHandler(TagConfig) l=
ine: 593=09
> CoreLibrary(AbstractTagLibrary).createTagHandler(String, String, TagConfi=
g) line: 98=09
> CompositeTagLibrary.createTagHandler(String, String, TagConfig) line: 93=
=09
> TagUnit.createFaceletHandler() line: 56=09
> TextUnit.createFaceletHandler() line: 104=09
> TagUnit(CompilationUnit).getNextFaceletHandler() line: 82=09
> TagUnit.getNextHandler() line: 61=09
> AbstractTagLibrary$ComponentConfigWrapper.getNextHandler() line: 431=09
> HtmlComponentHandler(TagHandler).<init>(TagConfig) line: 39=09
> HtmlComponentHandler(MetaTagHandler).<init>(TagConfig) line: 35=09
> HtmlComponentHandler(DelegatingMetaTagHandler).<init>(TagConfig) line: 40=
=09
> HtmlComponentHandler(ComponentHandler).<init>(ComponentConfig) line: 37=
=09
> HtmlComponentHandler.<init>(ComponentConfig) line: 37=09
> GeneratedConstructorAccessor17.newInstance(Object[]) line: not available=
=09
> DelegatingConstructorAccessorImpl.newInstance(Object[]) line: 27=09
> Constructor<T>.newInstance(Object...) line: 513=09
> AbstractTagLibrary$UserComponentHandlerFactory.createHandler(TagConfig) l=
ine: 519=09
> HtmlLibrary(AbstractTagLibrary).createTagHandler(String, String, TagConfi=
g) line: 98=09
> CompositeTagLibrary.createTagHandler(String, String, TagConfig) line: 93=
=09
> TagUnit.createFaceletHandler() line: 56=09
> TextUnit.createFaceletHandler() line: 104=09
> TagUnit(CompilationUnit).getNextFaceletHandler() line: 82=09

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrato=
rs: https://issues.apache.org/jira/secure/ContactAdministrators!default.jsp=
a
For more information on JIRA, see: http://www.atlassian.com/software/jira