Mailing-List: contact dev-help@myfaces.apache.org; run by ezmlm
Precedence: bulk
Reply-To: "MyFaces Development" <dev@myfaces.apache.org>
Date: Fri, 3 Feb 2012 21:15:00 +0000 (UTC)
From: =?utf-8?Q?Martin_Ko=C4=8D=C3=AD_=28Commented=29_=28JIRA=29?=
 <dev@myfaces.apache.org>
To: dev@myfaces.apache.org
Message-ID: 
 <1621668567.9043.1328303700878.JavaMail.tomcat@hel.zones.apache.org>
In-Reply-To: 
 <756967516.8957.1328302375056.JavaMail.tomcat@hel.zones.apache.org>
Subject: [jira] [Commented] (MYFACES-3459) RegexValidator does not provide
 label and pattern for first usage of RegexValidator.NOT_MATCHED
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable


    [ https://issues.apache.org/jira/browse/MYFACES-3459?page=3Dcom.atlassi=
an.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D13=
200046#comment-13200046 ]=20

Martin Ko=C4=8D=C3=AD commented on MYFACES-3459:
--------------------------------------

few observations:

# java.util.regex.Pattern.matcher(CharSequence) support CharSequence and we=
 can easily support it  too -> change instanceof check to "(value instanceo=
f CharSequence)"

# this instanceof check indicates disagreement between local value (convert=
ed) and type expected in validator - created '{1}: Validation Error: Value =
not according to pattern ''{0}''' is not suitable for this (mojarra thows C=
astClassExpception in the middle of validator and that is also not very pro=
per)

# javax.faces.validator.RegexValidator.PATTERN_NOT_SET and RegexValidator.M=
ATCH_EXCEPTION are completely missing in .properties files - or I can't fin=
d them


               =20
> RegexValidator does not provide label and pattern for first usage of Rege=
xValidator.NOT_MATCHED
> -------------------------------------------------------------------------=
----------------------
>
>                 Key: MYFACES-3459
>                 URL: https://issues.apache.org/jira/browse/MYFACES-3459
>             Project: MyFaces Core
>          Issue Type: Bug
>          Components: General
>    Affects Versions: 2.1.5
>         Environment: myfaces trunk
>            Reporter: Martin Ko=C4=8D=C3=AD
>            Assignee: Martin Ko=C4=8D=C3=AD
>            Priority: Trivial
>
> RegexValidator uses javax.faces.validator.RegexValidator.NOT_MATCHED 2x:
> javax.faces.validator.RegexValidator.NOT_MATCHED=3D the passed value is n=
ot a String, or when the pattern does not match the passed value.
> the first usage for" if (value instanceof String)" check does not provide=
 args for {0} {1} in message.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrato=
rs: https://issues.apache.org/jira/secure/ContactAdministrators!default.jsp=
a
For more information on JIRA, see: http://www.atlassian.com/software/jira