myfaces-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Leonardo Uribe (Issue Comment Edited) (JIRA)" <...@myfaces.apache.org>
Subject [jira] [Issue Comment Edited] (MYFACES-3455) [myfaces-2.1.6-SNAPSHOT] Using f:ajax within h:commandButton to dynamic switch ui:include works not correct anymore
Date Wed, 01 Feb 2012 15:52:58 GMT

    [ https://issues.apache.org/jira/browse/MYFACES-3455?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13197914#comment-13197914
] 

Leonardo Uribe edited comment on MYFACES-3455 at 2/1/12 3:51 PM:
-----------------------------------------------------------------

I checked the problem and it is caused because when f:facet contains more than one child,
facelets algorithm create a panel that is not backed by any facelet tag, but it has ComponentSupport.FACET_CREATED_UIPANEL_MARKER
to recognize it. Since it does not have ComponentSupport.MARK_CREATED associated, that panel
is marked to remove, but it should not.

The fix is just check that case on PostAddPreRemoveFromViewListener. It took me some time
to figure it out, but now it should work.

Thanks a lot for the test and the interest to check these cases, it is a very valuable contribution.
                
      was (Author: lu4242):
    I checked the problem and it is caused because when f:facet contains more than one child,
facelets algorithm create a panel that is not backed by any facelet tag, but it has ComponentSupport.FACET_CREATED_UIPANEL_MARKER
to recognize it. Since it does not have ComponentSupport.MARK_CREATED associated, that panel
is marked to remove, but it should note.

The fix is just check that case on PostAddPreRemoveFromViewListener. It took me some time
to figure it out, but now it should work.

Thanks a lot for the test and the interest to check these cases, it is a very valuable contribution.
                  
> [myfaces-2.1.6-SNAPSHOT] Using f:ajax within h:commandButton to dynamic switch ui:include
works not correct anymore
> -------------------------------------------------------------------------------------------------------------------
>
>                 Key: MYFACES-3455
>                 URL: https://issues.apache.org/jira/browse/MYFACES-3455
>             Project: MyFaces Core
>          Issue Type: Bug
>    Affects Versions: 2.1.6-SNAPSHOT
>            Reporter: Rene O
>            Assignee: Leonardo Uribe
>            Priority: Blocker
>             Fix For: 2.0.12, 2.1.6
>
>         Attachments: jsftest.war, jsftest2.war
>
>
> If you click the ajaxified commandButton the ui:include switches. 
> After a few clicks, the switch doesn't work correct anymore. You must click twice to
switch the include, which is a bug.
> A testcase to reproduce this issue is attached. Note, that this issue doesn't appear
within myfaces 2.1.5
> http://localhost:8080/jsftest/navtest.jsf

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message