Return-Path: X-Original-To: apmail-myfaces-dev-archive@www.apache.org Delivered-To: apmail-myfaces-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 66DB691D6 for ; Wed, 4 Jan 2012 01:49:26 +0000 (UTC) Received: (qmail 76551 invoked by uid 500); 4 Jan 2012 01:49:25 -0000 Delivered-To: apmail-myfaces-dev-archive@myfaces.apache.org Received: (qmail 76495 invoked by uid 500); 4 Jan 2012 01:49:25 -0000 Mailing-List: contact dev-help@myfaces.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: "MyFaces Development" Delivered-To: mailing list dev@myfaces.apache.org Received: (qmail 76318 invoked by uid 99); 4 Jan 2012 01:49:25 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 04 Jan 2012 01:49:25 +0000 X-ASF-Spam-Status: No, hits=-2001.6 required=5.0 tests=ALL_TRUSTED,RP_MATCHES_RCVD X-Spam-Check-By: apache.org Received: from [140.211.11.116] (HELO hel.zones.apache.org) (140.211.11.116) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 04 Jan 2012 01:49:24 +0000 Received: from hel.zones.apache.org (hel.zones.apache.org [140.211.11.116]) by hel.zones.apache.org (Postfix) with ESMTP id 2219413767B for ; Wed, 4 Jan 2012 01:48:40 +0000 (UTC) Date: Wed, 4 Jan 2012 01:48:40 +0000 (UTC) From: "Mike Kienenberger (Commented) (JIRA)" To: dev@myfaces.apache.org Message-ID: <1387123257.3119.1325641720141.JavaMail.tomcat@hel.zones.apache.org> In-Reply-To: <372719642.52341.1325187571327.JavaMail.tomcat@hel.zones.apache.org> Subject: [jira] [Commented] (TOMAHAWK-1607) focus cannot locate targets inside UIData elements MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/TOMAHAWK-1607?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13179218#comment-13179218 ] Mike Kienenberger commented on TOMAHAWK-1607: --------------------------------------------- Previous workaround left UIData in an inconsistent state causing unexpected issues. New version resets rowIndex and uses UIComponentPerspective to represent state. > focus cannot locate targets inside UIData elements > -------------------------------------------------- > > Key: TOMAHAWK-1607 > URL: https://issues.apache.org/jira/browse/TOMAHAWK-1607 > Project: MyFaces Tomahawk > Issue Type: Bug > Components: Focus > Affects Versions: 1.1.6 > Reporter: Mike Kienenberger > Assignee: Mike Kienenberger > Attachments: ExtendedHtmlFocus.java > > > focus cannot generate correct clientIds for targets inside UIData elements because UIComponent.findComponent() does not preserve row index information. > I noticed this in my legacy 1.1.6 app, but I suspect after glancing at the latest Tomahawk 1.1.9 code that the problem still persists. > However, I don't know how much focus is really used anymore -- it never made it out of the sandbox, and ajax makes doing much of this a lot easier now. > I created a workaround for focus by reimplementing a local version of findComponent() in a custom focus subclass and this workaround will work, except in those cases where a parent component had customized findComponent() behavior which I will attach to this issue. > A more modern solution would likely be to dump findComponent for invokeOnComponent which correctly sets the rowIndex. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira