myfaces-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Rudy De Busscher (Commented) (JIRA)" <...@myfaces.apache.org>
Subject [jira] [Commented] (EXTVAL-139) InformationProviderBean not cached
Date Wed, 04 Jan 2012 08:55:38 GMT

    [ https://issues.apache.org/jira/browse/EXTVAL-139?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13179354#comment-13179354
] 

Rudy De Busscher commented on EXTVAL-139:
-----------------------------------------

And there could be an issue when the "default" InformationProviderBean is cached.

If the bean is cached in the application scope on first access but a startup listener is used
to customize the DefaultExtValCoreConfiguration (like ExtValCoreConfiguration.use(CustomExtValCoreConfiguration,
true); where CustomExtValCoreConfiguration overwrites DefaultExtValCoreConfiguration.customInformationProviderBeanClassName()
) it is possible that this custom information provider bean isn't used. Because the execution
order of the PhaseListener's isn't determined.

However, we could provide a configuration option, true by default, that indicates if the "default"
InformationProviderBean should be cached.  This could fix the above scenario and provide the
caching.

I'll make a patch.
                
>  InformationProviderBean not cached 
> ------------------------------------
>
>                 Key: EXTVAL-139
>                 URL: https://issues.apache.org/jira/browse/EXTVAL-139
>             Project: MyFaces Extensions Validator
>          Issue Type: Bug
>          Components: Core
>    Affects Versions: 1.2.4
>         Environment: Mojarra 1.2_15, trinidad 1.2.14
>            Reporter: Markus Dreher
>            Priority: Minor
>
> the synchronized Method ExtValContextInternals.initInformationProviderBean is called
many times for each client request.
> We don't configured a custom InformationProviderBean.
> In line 71 the created "default" InformationProviderBean is just returned and not stored
in application scope.
> Custom InformationProviderBeans will be stored in application scope, so the method ist
just called once.
> Under heavy load, this could be a bottleneck

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message