myfaces-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Andrew Robinson (Reopened) (JIRA)" <...@myfaces.apache.org>
Subject [jira] [Reopened] (TRINIDAD-2203) UIXComponent does not check if in context when setupChildrenContext is called
Date Fri, 20 Jan 2012 02:55:40 GMT

     [ https://issues.apache.org/jira/browse/TRINIDAD-2203?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Andrew Robinson reopened TRINIDAD-2203:
---------------------------------------


Reopening as this causes false warnings with reentrant code and visitTree/invokeOnComponent.
Since the current component is not notified that a nested component traversal (visitTree)
is being made and the flags are no longer correct.
                
> UIXComponent does not check if in context when setupChildrenContext is called
> -----------------------------------------------------------------------------
>
>                 Key: TRINIDAD-2203
>                 URL: https://issues.apache.org/jira/browse/TRINIDAD-2203
>             Project: MyFaces Trinidad
>          Issue Type: Improvement
>          Components: Components
>    Affects Versions: 2.0.2-core
>            Reporter: Andrew Robinson
>            Assignee: Andrew Robinson
>             Fix For: 2.0.2-core
>
>
> UIXComponent has methods:
> setupVisitingContext
> setupChildrenEncodingContext
> setupEncodingContext
> setupChildrenVisitingContext
> and the corresponding tear down methods. The problem is that there is no code that validates
that these methods have not been called more than once at a time. For example, if a component
overrides the setupChildrenEncodingContext with code, and that method is called more than
once, it may cause issues. By adding boolean flags and simple checks with warnings to the
LOG it would be much easier for component authors to determine where the issue is instead
of just allowing, silently, the excessive calls to be made.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message