myfaces-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mike Kienenberger <mkien...@gmail.com>
Subject Re: Finding a checkstyle error
Date Mon, 28 Nov 2011 19:58:01 GMT
Thanks!

I looked in that file before, but it seemed as if it were just a huge
list of <file/> lines.

However, after filtering all of them out, I finally found the <error> tags.

<error line="1262" column="1" severity="error" message="File contains
tab characters (this is the first instance)."
source="com.puppycrawl.tools.checkstyle.checks.whitespace.FileTabCharacterCheck"/>

So the impl style errors are ones I introduced.   I'll fix them before
I commit the changes.

On Mon, Nov 28, 2011 at 2:50 PM, Mark Struberg <struberg@yahoo.de> wrote:
> hi, yes, the output is in target/checkstyle-result.xml
>
> LieGrue,
> strub
>
>
>
> ----- Original Message -----
>> From: Mike Kienenberger <mkienenb@gmail.com>
>> To: MyFaces Development <dev@myfaces.apache.org>; Mark Struberg <struberg@yahoo.de>
>> Cc:
>> Sent: Monday, November 28, 2011 8:44 PM
>> Subject: Re: Finding a checkstyle error
>>
>> Skipping the tests was done to reduce the amount of output since I'm
>> guessing that these checkstyle errors are being obscured by everything
>> else going on.
>>
>> Are you saying that the errors don't appear on the console, but are in
>> a report?  I couldn't find anything in a file under "targets"
>>
>> On Mon, Nov 28, 2011 at 2:39 PM, Mark Struberg <struberg@yahoo.de> wrote:
>>>  skipping tests wont help with checkstyle errors ;)
>>>  The checkstyle tests are not unit tests but is a plugin report which runs
>> afterwards.
>>>
>>>
>>>  I think we still have a few left, and the maven reactor stops after the
>> first failed project.
>>>
>>>
>>>  We need to clean this up, and I hope to find some time again in mid
>> december.
>>>
>>>  In the meantime please cd impl and run the checkstyle checks there.
>>>
>>>  LieGrue,
>>>  strub
>>>
>>>
>>>
>>>  ----- Original Message -----
>>>>  From: Mike Kienenberger <mkienenb@gmail.com>
>>>>  To: MyFaces Development <dev@myfaces.apache.org>; Mark Struberg
>> <struberg@yahoo.de>
>>>>  Cc:
>>>>  Sent: Monday, November 28, 2011 8:23 PM
>>>>  Subject: Re: Finding a checkstyle error
>>>>
>>>> & quot;mvn clean install -Pcheckstyle" didn't help.
>>>>
>>>>  Although it now says 3 errors on api instead of 1 on impl.
>>>>
>>>>  [ERROR] Failed to execute goal
>>>>  org.apache.maven.plugins:maven-checkstyle-plugin:2.7:check
>>>>  (verify-style) on project myfaces-api: You have 3 Checkstyle
>>>>  violations. -> [Help 1]
>>>>
>>>>  I only made a simple change on impl, so I'm thinking I'm not
>> the cause
>>>>  of the errors now.
>>>>
>>>>  I tried skipping all of the tests in hopes of trimming down the output
>>>>  further, but it still generates tons of information.   And sorting
>>>>  through this quickly still didn't find any actual checkstyle error
>>>>  lines.
>>>>
>>>>  mvn clean install -Pcheckstyle -Dmaven.test.skip=true
>>>>
>>>>  It seems as if a lot of the remaining output deals with javascript
>>>>  warnings.   Is there a way to also remove that?
>>>>
>>>>
>>>>  On Mon, Nov 28, 2011 at 2:08 PM, Mark Struberg
>> <struberg@yahoo.de> wrote:
>>>>>   just start maven with -Pcheckstyle
>>>>>
>>>>>   $> mvn clean install -Pcheckstyle
>>>>>
>>>>>
>>>>>   LieGrue,
>>>>>   strub
>>>>>
>>>>>
>>>>>
>>>>>   ----- Original Message -----
>>>>>>   From: Mike Kienenberger <mkienenb@gmail.com>
>>>>>>   To: MyFaces Development <dev@myfaces.apache.org>
>>>>>>   Cc:
>>>>>>   Sent: Monday, November 28, 2011 7:58 PM
>>>>>>   Subject: Finding a checkstyle error
>>>>>>
>>>>>>   So how do I find the actual checkstyle error when building
>> trunk 2.1?
>>>>>>
>>>>>>   [INFO] --- maven-checkstyle-plugin:2.7:check (verify-style) @
>>>>  myfaces-impl ---
>>>>>>   [INFO]
>>>>>>   [INFO] There are 1 checkstyle errors.
>>>>>>   [INFO]
>>>>
>> ------------------------------------------------------------------------
>>>>>>   [INFO] Reactor Summary:
>>>>>>   [INFO]
>>>>>>   [INFO] Apache MyFaces JSF-2.1 Core Project ...............
>> SUCCESS
>>>>  [4.516s]
>>>>>>   [INFO] Apache MyFaces JSF-2.1 Core API ...................
>> SUCCESS
>>>>  [18.635s]
>>>>>>   [INFO] Apache MyFaces Core For JSF 2.1 - Shared ..........
>> SUCCESS
>>>>  [6.069s]
>>>>>>   [INFO] Apache MyFaces JSF-2.1 Core Shaded Impl ...........
>> SUCCESS
>>>>  [10.875s]
>>>>>>   [INFO] Apache MyFaces JSF-2.1 Core Impl for Java EE 6 ....
>> SUCCESS
>>>>  [2.399s]
>>>>>>   [INFO] Apache MyFaces JSF-2.1 Core Impl ..................
>> FAILURE
>>>>  [40.539s]
>>>>>>   [INFO] Apache MyFaces JSF-2.1 Core OSGi Bundle ...........
>> SKIPPED
>>>>>>   [INFO]
>>>>
>> ------------------------------------------------------------------------
>>>>>>   [INFO] BUILD FAILURE
>>>>>>   [INFO]
>>>>
>> ------------------------------------------------------------------------
>>>>>>   [INFO] Total time: 1:24.902s
>>>>>>   [INFO] Finished at: Mon Nov 28 13:54:12 EST 2011
>>>>>>   [INFO] Final Memory: 45M/261M
>>>>>>   [INFO]
>>>>
>> ------------------------------------------------------------------------
>>>>>>   [ERROR] Failed to execute goal
>>>>>>   org.apache.maven.plugins:maven-checkstyle-plugin:2.7:check
>>>>>>   (verify-style) on project myfaces-impl: You have 1 Checkstyle
>>>>>>   violation. -> [Help 1]
>>>>>>
>>>>>
>>>>
>>>
>>
>

Mime
View raw message