Return-Path: X-Original-To: apmail-myfaces-dev-archive@www.apache.org Delivered-To: apmail-myfaces-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 2EFDE99E3 for ; Thu, 27 Oct 2011 14:41:29 +0000 (UTC) Received: (qmail 88951 invoked by uid 500); 27 Oct 2011 14:41:28 -0000 Delivered-To: apmail-myfaces-dev-archive@myfaces.apache.org Received: (qmail 88914 invoked by uid 500); 27 Oct 2011 14:41:28 -0000 Mailing-List: contact dev-help@myfaces.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: "MyFaces Development" Delivered-To: mailing list dev@myfaces.apache.org Received: (qmail 88907 invoked by uid 99); 27 Oct 2011 14:41:28 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 27 Oct 2011 14:41:28 +0000 X-ASF-Spam-Status: No, hits=-0.7 required=5.0 tests=FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (athena.apache.org: domain of mkienenb@gmail.com designates 74.125.82.181 as permitted sender) Received: from [74.125.82.181] (HELO mail-wy0-f181.google.com) (74.125.82.181) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 27 Oct 2011 14:41:24 +0000 Received: by wyh5 with SMTP id 5so3385397wyh.12 for ; Thu, 27 Oct 2011 07:41:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :content-type:content-transfer-encoding; bh=6m+iBNNh9WryFBnzn646bdp7u5wbx+yQY679Zgbi6iU=; b=MKh1fv/L88rXx3/zF6rZd1Cf/GWRiDA2cobZoo5Ffq7Q1fJHgcriKtTssvjpezUCge 6deYweF/IxRYRAPOcLjcOFqAlth6ogiCFyE2lhBtL2p9Of7558iV8pR+P1ZCcmfE8usg eXCFINktIz+EpkfHT5GqJS4aM+dCl9ptqIxwk= Received: by 10.216.131.163 with SMTP id m35mr13554791wei.70.1319726463096; Thu, 27 Oct 2011 07:41:03 -0700 (PDT) MIME-Version: 1.0 Received: by 10.216.123.74 with HTTP; Thu, 27 Oct 2011 07:40:42 -0700 (PDT) In-Reply-To: <1319725929.13770.YahooMailNeo@web27805.mail.ukl.yahoo.com> References: <1319723593.11255.YahooMailNeo@web27807.mail.ukl.yahoo.com> <1319725322.10302.YahooMailNeo@web27806.mail.ukl.yahoo.com> <1319725929.13770.YahooMailNeo@web27805.mail.ukl.yahoo.com> From: Mike Kienenberger Date: Thu, 27 Oct 2011 10:40:42 -0400 Message-ID: Subject: Re: StateHolder#isTransient equals and hashCode question To: MyFaces Development , Mark Struberg Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Please don't take my word for it. I am guessing somewhat here. I admit that I don't really know. But it does seem like equality and saved state should be related. On Thu, Oct 27, 2011 at 10:32 AM, Mark Struberg wrote: > oki, thanks for this info! > > LieGrue, > strub > > > > ----- Original Message ----- >> From: Mike Kienenberger >> To: MyFaces Development ; Mark Struberg >> Cc: >> Sent: Thursday, October 27, 2011 4:25 PM >> Subject: Re: StateHolder#isTransient equals and hashCode question >> >> Yes, I know that. >> >> But since it is not part of the state, and would be lost anyway on a >> saveState/restoreState, I don't think it needs to be considered for >> equals. >> >> It seems to be a transient value :) >> >> On Thu, Oct 27, 2011 at 10:22 AM, Mark Struberg wrot= e: >>> =A0Hi Mike! >>> >>> =A0_transient is _not_ a transient value, but is the value returned by >> StateHolder#isTransient() >>> >>> >> http://javaserverfaces.java.net/nonav/docs/2.0/javadocs/javax/faces/comp= onent/StateHolder.html#isTransient%28%29 >>> >>> =A0LieGrue, >>> =A0strub >>> >>> >>> >>> =A0----- Original Message ----- >>>> =A0From: Mike Kienenberger >>>> =A0To: MyFaces Development >>>> =A0Cc: >>>> =A0Sent: Thursday, October 27, 2011 4:20 PM >>>> =A0Subject: Re: StateHolder#isTransient equals and hashCode question >>>> >>>> =A0I think it is ok to ignore transient values for equals/hasCode sinc= e >>>> =A0it is also not saved as part of the state.=A0 But I'm not an expert= . >>>> >>>> >>>> =A0On Thu, Oct 27, 2011 at 9:53 AM, Mark Struberg >> wrote: >>>>> =A0=A0Hi! >>>>> >>>>> =A0=A0we have lots of classes which implement equals but no hashCode(= ) - >> this is >>>> =A0bad. >>>>> >>>>> =A0=A0e.g. DoubleRangeValidator has an equals but doesn't include >> _transient >>>> =A0in it's comparison. Is this ok? >>>>> >>>>> =A0=A0LieGrue, >>>>> =A0=A0strub >>>>> >>>>> >>>> >>> >> >