Mailing-List: contact dev-help@myfaces.apache.org; run by ezmlm
Precedence: bulk
Reply-To: "MyFaces Development" <dev@myfaces.apache.org>
Received-SPF: pass (nike.apache.org: domain of lu4242@gmail.com designates
 209.85.210.47 as permitted sender)
MIME-Version: 1.0
In-Reply-To: <1319663830.11779.YahooMailNeo@web27802.mail.ukl.yahoo.com>
References: <1319653085.69405.YahooMailNeo@web27808.mail.ukl.yahoo.com>
	<CABujnVcj6MkoWKTeSjiHH2ajg5pMrsZehOSTEfsnRYTz2Jjh8w@mail.gmail.com>
	<1319660775.71579.YahooMailNeo@web27802.mail.ukl.yahoo.com>
	<CABujnVe4T2hiBHEOJvkJyJfWZT3npvfDfgAfZaqshqMcXSMofA@mail.gmail.com>
	<1319663830.11779.YahooMailNeo@web27802.mail.ukl.yahoo.com>
Date: Wed, 26 Oct 2011 16:43:12 -0500
Message-ID: 
 <CABujnVe__RGXuiKLh-qvvv2rFr7fAdQw1d=ABLeB6hWHxcK95Q@mail.gmail.com>
Subject: Re: MYFACES-3368 status
From: Leonardo Uribe <lu4242@gmail.com>
To: MyFaces Development <dev@myfaces.apache.org>,
 Mark Struberg <struberg@yahoo.de>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable

Hi

In NavigationHandlerImpl#_navigationCases, that var should be
volatile, but note if it is not nothing happens, just the code will be
executed more times than necessary.

regards,

Leonardo Uribe

2011/10/26 Mark Struberg <struberg@yahoo.de>:
> For example
> NavigationHandlerImpl#_navigationCases
>
> I already fixed a few occurrences.
>
> There are also a few other checkstyle errors waiting to get fixed like me=
thods which are 450 lines long..
>
> Would be cool if you could take a look at it - txs!
>
>
> LieGrue,
> strub
>
>
>
> ----- Original Message -----
>> From: Leonardo Uribe <lu4242@gmail.com>
>> To: myfaces-dev <dev@myfaces.apache.org>; Mark Struberg <struberg@yahoo.=
de>
>> Cc:
>> Sent: Wednesday, October 26, 2011 10:45 PM
>> Subject: Re: MYFACES-3368 status
>>
>> Yes I know that, but where in myfaces we have a problem like that? so
>> we can discuss it in deep.
>>
>> 2011/10/26 Mark Struberg <struberg@yahoo.de>:
>>> =A0Again (think I posted this before already), a very good source for j=
ava mem
>> spec behaviour is the comment of Brian Goetz
>>>
>>> =A0http://www.cs.umd.edu/~pugh/java/memoryModel/jsr-133-faq.html
>>>
>>> =A0This also explains why you need to declare the field volatile - don'=
t
>> wanna stress this, but I told this also before... ;)
>>>
>>>
>>> =A0LieGrue,
>>> =A0strub
>>>
>>>
>>>
>>>
>>>
>>> =A0----- Original Message -----
>>>> =A0From: Leonardo Uribe <lu4242@gmail.com>
>>>> =A0To: MyFaces Development <dev@myfaces.apache.org>; Mark Struberg
>> <struberg@yahoo.de>
>>>> =A0Cc:
>>>> =A0Sent: Wednesday, October 26, 2011 8:40 PM
>>>> =A0Subject: Re: MYFACES-3368 status
>>>>
>>>> =A0Hi
>>>>
>>>> =A0I'm keeping an eye on the changes done. I don't remember any
>> problem
>>>> =A0about 'double lock' on myfaces. Could you please be more
>> specific? In
>>>> =A0my understanding everything works as expected.
>>>>
>>>> =A0regards,
>>>>
>>>> =A0Leonardo Uribe
>>>>
>>>> =A02011/10/26 Mark Struberg <struberg@yahoo.de>:
>>>>> =A0=A0Hi folks!
>>>>>
>>>>> =A0=A0I'm down to 24 checkstyle issues (with LineLength=3D160,
>> otherwise ~600
>>>> =A0more) which are really non-trivial.
>>>>>
>>>>> =A0=A0A few of them are 'equals() without hashCode()' which are
>>>> =A0definitely problematic
>>>>> =A0=A0Then we have a few variable namings which I didn't want to
>> change
>>>> =A0without talking to you.
>>>>> =A0=A0And of course there are some 'double lock idiom' issues.
>>>>> =A0=A0It's safe to use double-locking as of Java5, but ONLY if the
>> locked
>>>> =A0variable is declared volatile! We barely have this, so I left the c=
heck
>>>> =A0enabled...
>>>>>
>>>>>
>>>>> =A0=A0Who is taking care of those remaining issues? Leo?
>>>>>
>>>>>
>>>>> =A0=A0LieGrue,
>>>>> =A0=A0strub
>>>>>
>>>>>
>>>>
>>>
>>
>