Mailing-List: contact dev-help@myfaces.apache.org; run by ezmlm
Precedence: bulk
Reply-To: "MyFaces Development" <dev@myfaces.apache.org>
Received-SPF: neutral (nike.apache.org: local policy)
DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws;
  s=s1024; d=yahoo.de;
  h=X-YMail-OSG:Received:X-Mailer:References:Message-ID:Date:From:Reply-To:Subject:To:In-Reply-To:MIME-Version:Content-Type:Content-Transfer-Encoding;
  b=wacfurb7hQh+KwPxsAgJH8iQctfRLfGRMLGQCMVMUZMLtpkcy44XdAzR9nbkSeB6xJh1X4JA5zq39GR1ycv1h8ahHCUlGzMjnTAwIp6BBp5YtNojjKR0ahC9+ubGEY457TIYvn/uFEYKZSrl02qM+V2eh/ndwn09cY7mz1gUnKs=;
References: <1319631539.99211.YahooMailNeo@web27805.mail.ukl.yahoo.com>
 <CAHeGRnqNP_ftk4r=zSwQoj7CuHGzMVWYjyaLw=2KUUZQ_F9x_Q@mail.gmail.com>
 <1319790456.37436.YahooMailNeo@web27807.mail.ukl.yahoo.com>
Message-ID: <1319792382.39802.YahooMailNeo@web27802.mail.ukl.yahoo.com>
Date: Fri, 28 Oct 2011 09:59:42 +0100 (BST)
From: Mark Struberg <struberg@yahoo.de>
Reply-To: Mark Struberg <struberg@yahoo.de>
Subject: Re: [VOTE] extend maximum allowed line length from 120 to 160
To: MyFaces Development <dev@myfaces.apache.org>
In-Reply-To: <1319790456.37436.YahooMailNeo@web27807.mail.ukl.yahoo.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Transfer-Encoding: quoted-printable

Hi Volker, =0A=0AI already fixed 1111 issues in myfaces-core-api and about =
another 1000 in myfaces-core-impl (not only line-length).=0AWe had a lot li=
nes which even exceeded the 160 chars, but I was really tired already and r=
elaxed my own local checkstyle rules to 160 chars now. =0A=0ABut since you =
are a MyFaces Committer (even PMC) too, I'm perfectly =0Afine with 120 if y=
ou could volunteer and fix another 600 checkstyle issues =0Abecause of that=
 - thanks a lot in advance!=0A=0AIt's pretty easy. Just go to myfaces/core/=
impl and run=0A=0A$:> mvn checkstyle:check -Pcheckstyle=0A=0Ayou then get a=
ll the checkstyle errors in a file=0A=0A$:> less target/checkstyle-results.=
xml=0A=0Ajust search for 'error'.=0A=0Atxs again and LieGrue,=0Astrub=0A=0A=
=0A=0A----- Original Message -----=0A> From: Mark Struberg <struberg@yahoo.=
de>=0A> To: myfaces-dev <dev@myfaces.apache.org>=0A> Cc: =0A> Sent: Friday,=
 October 28, 2011 10:27 AM=0A> Subject: Re: [VOTE] extend maximum allowed l=
ine length from 120 to 160=0A> =0A> Volker, source code is no newspaper.=0A=
> =0A> Imo 80 chars is definitely fine for C or perl with cryptic syntax (p=
rogrammed =0A> that myself for 20 years) but it's not nice for languages wh=
ere descriptive =0A> variable and method names are 'socially accepted' ;)=
=0A> =0A> =0A> LieGrue,=0A> strub=0A> =0A> =0A> =0A> ----- Original Message=
 -----=0A>>  From: Volker Weber <v.weber@inexso.de>=0A>>  To: MyFaces Devel=
opment <dev@myfaces.apache.org>; Mark Struberg =0A> <struberg@yahoo.de>=0A>=
>  Cc: =0A>>  Sent: Friday, October 28, 2011 9:22 AM=0A>>  Subject: Re: [VO=
TE] extend maximum allowed line length from 120 to 160=0A>> =0A>>  Hi,=0A>>=
 =0A>>  -1.=0A>> =0A>>  In my opinion 160 characters is much to wide, the c=
urrent 120 is not=0A>>  the preferred, but the allowed max width.=0A>>  I v=
ote for 80 characters as preferred max width.=0A>> =0A>>  In general readin=
g is easier if the text is not too wide, thats why=0A>>  newspaper articles=
 are layouted in columns.=0A>> =0A>> =0A>>  Regards,=0A>>  =A0 =A0 Volker=
=0A>> =0A>>  2011/10/26 Mark Struberg <struberg@yahoo.de>:=0A>>> =A0 Hi!=0A=
>>> =0A>>> =A0 Currently we have really long and very descriptive variable =
names in =0A>>  MyFaces.=0A>>> =0A>>> =A0 I personally like that, but due t=
o that we are really often exceeding =0A> the =0A>>  120 character per line=
.=0A>>> =0A>>> =A0 Thus my question: should we extend this from 120 to 160 =
characters =0A> being =0A>>  allowed per line?=0A>>> =0A>>> =A0 [+1] yup ma=
ke 160 the max default=0A>>> =A0 [0] don't care=0A>>> =A0 [-1] nope, let's =
stick with 120=0A>>> =0A>>> =A0 open for 72h ...=0A>>> =0A>>> =0A>>> =A0 Pl=
ease make use of your vote, because I will activate the checkstyle =0A> che=
cks =0A>>  soon ;)=0A>>> =0A>>> =A0 here is my +1.=0A>>> =0A>>> =A0 LieGrue=
,=0A>>> =A0 strub=0A>>> =0A>>> =0A>> =0A>> =0A>> =0A>>  -- =0A>>  inexso - =
information exchange solutions GmbH=0A>>  Ofener Str. 30 =A0 =A0 =A0| 26121=
 Oldenburg=0A>>  Tel.: +49 441 219 730 56 |=0A>>  FAX: =A0+49 441 219 730 6=
6 | eMail: volker.weber@inexso.de=0A>> =0A>>  Firmensitz: Oldenburg | Amtsg=
ericht Oldenburg HRB 205251=0A>>  Gesch=E4ftsf=FChrer: Stefan Schulte, Mich=
ael Tersch=FCren=0A>> =0A>