myfaces-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mike Kienenberger <mkien...@gmail.com>
Subject Re: StateHolder#isTransient equals and hashCode question
Date Thu, 27 Oct 2011 14:40:42 GMT
Please don't take my word for it.   I am guessing somewhat here.   I
admit that I don't really know.   But it does seem like equality and
saved state should be related.

On Thu, Oct 27, 2011 at 10:32 AM, Mark Struberg <struberg@yahoo.de> wrote:
> oki, thanks for this info!
>
> LieGrue,
> strub
>
>
>
> ----- Original Message -----
>> From: Mike Kienenberger <mkienenb@gmail.com>
>> To: MyFaces Development <dev@myfaces.apache.org>; Mark Struberg <struberg@yahoo.de>
>> Cc:
>> Sent: Thursday, October 27, 2011 4:25 PM
>> Subject: Re: StateHolder#isTransient equals and hashCode question
>>
>> Yes, I know that.
>>
>> But since it is not part of the state, and would be lost anyway on a
>> saveState/restoreState, I don't think it needs to be considered for
>> equals.
>>
>> It seems to be a transient value :)
>>
>> On Thu, Oct 27, 2011 at 10:22 AM, Mark Struberg <struberg@yahoo.de> wrote:
>>>  Hi Mike!
>>>
>>>  _transient is _not_ a transient value, but is the value returned by
>> StateHolder#isTransient()
>>>
>>>
>> http://javaserverfaces.java.net/nonav/docs/2.0/javadocs/javax/faces/component/StateHolder.html#isTransient%28%29
>>>
>>>  LieGrue,
>>>  strub
>>>
>>>
>>>
>>>  ----- Original Message -----
>>>>  From: Mike Kienenberger <mkienenb@gmail.com>
>>>>  To: MyFaces Development <dev@myfaces.apache.org>
>>>>  Cc:
>>>>  Sent: Thursday, October 27, 2011 4:20 PM
>>>>  Subject: Re: StateHolder#isTransient equals and hashCode question
>>>>
>>>>  I think it is ok to ignore transient values for equals/hasCode since
>>>>  it is also not saved as part of the state.  But I'm not an expert.
>>>>
>>>>
>>>>  On Thu, Oct 27, 2011 at 9:53 AM, Mark Struberg
>> <struberg@yahoo.de> wrote:
>>>>>   Hi!
>>>>>
>>>>>   we have lots of classes which implement equals but no hashCode()
-
>> this is
>>>>  bad.
>>>>>
>>>>>   e.g. DoubleRangeValidator has an equals but doesn't include
>> _transient
>>>>  in it's comparison. Is this ok?
>>>>>
>>>>>   LieGrue,
>>>>>   strub
>>>>>
>>>>>
>>>>
>>>
>>
>

Mime
View raw message