myfaces-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Mark Struberg (Commented) (JIRA)" <...@myfaces.apache.org>
Subject [jira] [Commented] (MYFACES-3368) enable 'standard' checkstyle checks in myfaces-core
Date Thu, 27 Oct 2011 20:40:33 GMT

    [ https://issues.apache.org/jira/browse/MYFACES-3368?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13137507#comment-13137507
] 

Mark Struberg commented on MYFACES-3368:
----------------------------------------

Leo, can you please check the following methods heavily exceed the (already extended) line
limit for methods (300 LOC) and split them into several smaller chunks?

AnnotationConfigurator#createFacesConfig
ComponentTagHandlerDelegate#apply
FaceletViewDeclarationLanguage#retargetMethodExpressions

I think it's better if you do that because you are way more into meaningful details of the
code than I am. - txs!

                
> enable 'standard' checkstyle checks in myfaces-core
> ---------------------------------------------------
>
>                 Key: MYFACES-3368
>                 URL: https://issues.apache.org/jira/browse/MYFACES-3368
>             Project: MyFaces Core
>          Issue Type: Improvement
>    Affects Versions: 2.1.3
>            Reporter: Mark Struberg
>            Assignee: Mark Struberg
>
> We currently only have the 'minimal' checks enabled in core, which actually only checks
the correct license headers.
> We should go for the 'standard' checkstyle rules, even if this would take some time to
fix (found 1111 errors only in the first module).

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message