myfaces-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Mark Struberg (Commented) (JIRA)" <>
Subject [jira] [Commented] (MYFACES-3368) enable 'standard' checkstyle checks in myfaces-core
Date Mon, 24 Oct 2011 10:07:32 GMT


Mark Struberg commented on MYFACES-3368:

> but if someone force me to use '_ ' for variable name in tobago i will stop my work.

hehe au contraire - no worries, it's exactly the other way around :)

Currently we have a lot of code which uses _variableName even for method parameters and local
method variables.
This is just plain ugly and wrong - and our standard checkstyle rules even raise this as an
error! So no worries, NOT writing _ will always work, but using _variableName is only allowed
for class members (again, you _can_ use it but you don't need to).

> enable 'standard' checkstyle checks in myfaces-core
> ---------------------------------------------------
>                 Key: MYFACES-3368
>                 URL:
>             Project: MyFaces Core
>          Issue Type: Improvement
>    Affects Versions: 2.1.3
>            Reporter: Mark Struberg
>            Assignee: Mark Struberg
> We currently only have the 'minimal' checks enabled in core, which actually only checks
the correct license headers.
> We should go for the 'standard' checkstyle rules, even if this would take some time to
fix (found 1111 errors only in the first module).

This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:!default.jspa
For more information on JIRA, see:


View raw message