myfaces-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Leonardo Uribe (Commented) (JIRA)" <>
Subject [jira] [Commented] (MYFACES-3368) enable 'standard' checkstyle checks in myfaces-core
Date Fri, 28 Oct 2011 05:24:32 GMT


Leonardo Uribe commented on MYFACES-3368:

Ok, no problem, but give me some time, I want to commit MYFACES-3259 first and this patch
changes ComponentTagHandlerDelegate#apply. The one I really don't want to change is FaceletViewDeclarationLanguage#retargetMethodExpressions,
because it is a difficult algorithm and have it as is makes easier read it and update it.
But I have lots of junit tests for that one, so after all it is ok to refactor it.
> enable 'standard' checkstyle checks in myfaces-core
> ---------------------------------------------------
>                 Key: MYFACES-3368
>                 URL:
>             Project: MyFaces Core
>          Issue Type: Improvement
>    Affects Versions: 2.1.3
>            Reporter: Mark Struberg
>            Assignee: Leonardo Uribe
> We currently only have the 'minimal' checks enabled in core, which actually only checks
the correct license headers.
> We should go for the 'standard' checkstyle rules, even if this would take some time to
fix (found 1111 errors only in the first module).

This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:!default.jspa
For more information on JIRA, see:


View raw message