myfaces-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mark Struberg <strub...@yahoo.de>
Subject Re: Commit r1188515
Date Tue, 25 Oct 2011 09:47:14 GMT
I now compared our version with the one (actually two, lang and lang3) from commons, and although
one can see that they have common origins, they are now pretty different already. Thus I see
no reason why not to drop the _ from the variable names.

LieGrue,
strub



----- Original Message -----
> From: Mark Struberg <struberg@yahoo.de>
> To: myfaces-dev <dev@myfaces.apache.org>
> Cc: 
> Sent: Tuesday, October 25, 2011 10:07 AM
> Subject: Commit r1188515
> 
> ------------------------------------------------------------------------
> r1188515 | lu4242 | 2011-10-25 07:13:01 +0200 (Di, 25 Okt 2011) | 1 line
> 
> MYFACES-3368 enable 'standard' checkstyle checks in myfaces-core (revert 
> some changes on LocaleUtils because it is a copy of a class in commons-lang, so 
> it is better to keep it without changes, fix UIComponentTagBase signature and 
> some intentional usages of final modifier)
> 
> Leo, if you like to explicitely like to treat some files different, then please 
> add them to the exclude section in the maven-checkstyle-plugin config.
> 
> txs and LieGrue,
> strub
>

Mime
View raw message