myfaces-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Leonardo Uribe (JIRA)" <...@myfaces.apache.org>
Subject [jira] [Commented] (MYFACES-3309) Throw correct exception while using FactoryFinderProvider SPI
Date Mon, 19 Sep 2011 18:19:08 GMT

    [ https://issues.apache.org/jira/browse/MYFACES-3309?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13108038#comment-13108038
] 

Leonardo Uribe commented on MYFACES-3309:
-----------------------------------------

I don't think so. This looks like an improvement, instead a bug. It is true the try/catch
block wraps all exceptions into a FacesException,and instead it should throw the exceptions
like the javadoc of FactoryFinder says. Anyway, the real cause can be found using getCause(),
so in practice it is possible to add some code that check that. 

> Throw correct exception while using FactoryFinderProvider SPI
> -------------------------------------------------------------
>
>                 Key: MYFACES-3309
>                 URL: https://issues.apache.org/jira/browse/MYFACES-3309
>             Project: MyFaces Core
>          Issue Type: Bug
>          Components: SPI
>    Affects Versions: 2.0.9, 2.1.3
>            Reporter: Ivan
>         Attachments: MYFACES-3309.patch
>
>
> While using FactoryFinderProvider SPI, it is required to check the real exception from
InvocationTargetException, and throw some exceptions directly.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message