myfaces-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Kennard Consulting (JIRA)" <...@myfaces.apache.org>
Subject [jira] [Commented] (MYFACES-3293) REGRESSION: 2.0.5->2.0.6: RendererUtils.renderChild no longer checks isRendered
Date Mon, 29 Aug 2011 12:25:38 GMT

    [ https://issues.apache.org/jira/browse/MYFACES-3293?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13092803#comment-13092803
] 

Kennard Consulting commented on MYFACES-3293:
---------------------------------------------

Okay great. Now opened as MYFACES-3294.

> REGRESSION: 2.0.5->2.0.6: RendererUtils.renderChild no longer checks isRendered
> -------------------------------------------------------------------------------
>
>                 Key: MYFACES-3293
>                 URL: https://issues.apache.org/jira/browse/MYFACES-3293
>             Project: MyFaces Core
>          Issue Type: Bug
>    Affects Versions: 2.0.6, 2.0.7
>            Reporter: Kennard Consulting
>         Attachments: addressbook-faces2-src.zip, addressbook-faces2.war, addressbook-faces2.war
>
>
> Hi guys,
> Thanks for all the work you do on MyFaces. It is such a robust JSF implementation.
> There appears to have been a regression between 2.0.5 and 2.0.6/2.0.7? Specifically,
RendererUtils.renderChild no longer does an 'upfront' check of whether a UIComponent is rendered
or not. This logic appears flawed if the UIComponent does *not* render its own children (the
default in Renderer.getRendersChildren)?
> First, encodeBegin/encodeEnd for the UIComponent will skip (the default in UIComponentBase.encodeBegin).
But encodeChildren for the UIComponent will not get called (because getRendersChildren is
false), so the UIComponent has no opportunity to prevent rendering of its children. Instead
RendererUtils will invoke encodeBegin/encodeEnd on each child directly. So if a rendered component
is nested inside a non-rendered component, it will still appear.
> Surely there is an implication that even if I elect not to render my own children (i.e.
I let JSF handle it), they should not get rendered if I myself am not rendered?
> I enclose a small project that demonstrates the issue. Hopefully it is sufficient to
debug. If not I can try and untangle it from Metawidget.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message