myfaces-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Bastian Voigt (JIRA)" <...@myfaces.apache.org>
Subject [jira] [Commented] (MYFACES-3195) NumberConverter ignores groupingUsed attribute when parsing
Date Wed, 31 Aug 2011 10:29:09 GMT

    [ https://issues.apache.org/jira/browse/MYFACES-3195?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13094417#comment-13094417
] 

Bastian Voigt commented on MYFACES-3195:
----------------------------------------

OK, another example:

Assume we have a text field like so:

<h:inputText value="#{userBean.someNumber}">
<f:convertNumber type="number" groupingUsed="#{true}" />
</h:inputText>

And a backing bean like this:

class UserBean {
  double someNumber;
  void setSomeNumber(double d) {
    this.someNumber=d;    
  }
}

And we input the number 4,096.23 using the English locale.

The result is 4.

> NumberConverter ignores groupingUsed attribute when parsing
> -----------------------------------------------------------
>
>                 Key: MYFACES-3195
>                 URL: https://issues.apache.org/jira/browse/MYFACES-3195
>             Project: MyFaces Core
>          Issue Type: Bug
>          Components: General
>    Affects Versions: 2.0.7
>         Environment: Linux, Tomcat, Spring, Hibernate, ... (please ask for more details)
>            Reporter: Bastian Voigt
>            Assignee: Leonardo Uribe
>
> javax.faces.convert.NumberConverter uses the "groupingUsed" attribute only for formatting,
but not for parsing numbers. This leads to a nasty bug:
> When I input the value "0.23" in an input field using a German locale, it is converted
to "23.00", which is bad.
> Proposed patch, in method getAsObject():
>                 NumberFormat format = getNumberFormat(facesContext);
>                 format.setParseIntegerOnly(_integerOnly);
> +              format.setGroupingUsed(_groupingUsed);

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message