myfaces-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Leonardo Uribe <lu4...@gmail.com>
Subject Re: Proposal: Get rid of shaded-impl module in core 2.1.x
Date Fri, 08 Jul 2011 16:33:47 GMT
Hi

Thinking more about it, I have a question about this change. The
intention of shaded-impl, is do some hack to allow use some classes
provided in impl (spi package, StartupServletExternalContextImpl ... )
for implee6 module. As soon as our implementation requires JDK 1.6,
this hack will be gone, and maybe that will be on 2.2.x, right? (but
the idea is keep compatibility with previous JDK even if JSF 2.1
claims it requires JDK 1.6 or upper). On the patch proposed I see a
refactor of the spi and a call to StartupServletExternalContextImpl
using reflection. My question is it is worth that change?, given this
module will only be living for a short time and it will be removed
sooner or later? Does that module suppose an unnecessary complexity?.

regards,

Leonardo Uribe

2011/7/8 Leonardo Uribe <lu4242@gmail.com>:
> Hi
>
> In principle I agree with this change, but after a quick patch review
> I saw some package relocation for some classes (from
> org.apache.myfaces.config.element to org.apache.myfaces.spi.data).
> Those changes will break extensions scripting code. Such changes
> should be done between major versions (2.2.0). Please do not change
> the package names.
>
> regards,
>
> Leonardo Uribe
>
> 2011/7/8 Gerhard Petracek <gerhard.petracek@gmail.com>:
>> +1
>> regards,
>> gerhard
>>
>> http://www.irian.at
>>
>> Your JSF powerhouse -
>> JSF Consulting, Development and
>> Courses in English and German
>>
>> Professional Support for Apache MyFaces
>>
>>
>>
>> 2011/7/8 Jakob Korherr <jakob.korherr@gmail.com>
>>>
>>> Hi guys,
>>>
>>> We currently use the shaded-impl module in core 2.1.x to solve a
>>> cyclic dependency problem. However, this introduces redundancy and
>>> complexity and may lead to some strange issues. This can be solved by
>>> the introduction of a myfaces-spi module (which is then packed
>>> together with myfaces-impl, just like myfaces-impl-ee6 is).
>>>
>>> Please see MYFACES-3211 [1] for a detailed description of the solution
>>> and a patch for it.
>>>
>>> If there are no objections, I will commit this patch soon!
>>>
>>> Regards,
>>> Jakob
>>>
>>> [1] https://issues.apache.org/jira/browse/MYFACES-3211
>>>
>>> --
>>> Jakob Korherr
>>>
>>> blog: http://www.jakobk.com
>>> twitter: http://twitter.com/jakobkorherr
>>> work: http://www.irian.at
>>
>>
>

Mime
View raw message