myfaces-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Leonardo Uribe (JIRA)" <...@myfaces.apache.org>
Subject [jira] [Updated] (MYFACES-3234) FacesContextImpl.getPartialViewContext() does not use wrapped context but only (this)
Date Thu, 21 Jul 2011 00:27:57 GMT

     [ https://issues.apache.org/jira/browse/MYFACES-3234?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Leonardo Uribe updated MYFACES-3234:
------------------------------------

       Resolution: Fixed
    Fix Version/s: 2.1.2
                   2.0.8
           Status: Resolved  (was: Patch Available)

It is ok to call FacesContext.getCurrentInstance(), because after all the created instance
is cached, so in practice it is only one call per request, so the final impact is minimal.
The preferred way is create a PartialViewContextFactory wrapper, but this strategy should
work too (to ensure the wrapper is on top, but anyway faces-config ordering should fix that
too) . Thanks to Martin Koci for provide this patch.

> FacesContextImpl.getPartialViewContext() does not use wrapped context but only (this)
> -------------------------------------------------------------------------------------
>
>                 Key: MYFACES-3234
>                 URL: https://issues.apache.org/jira/browse/MYFACES-3234
>             Project: MyFaces Core
>          Issue Type: Bug
>          Components: JSR-314
>         Environment: myfaces trunk
>            Reporter: Martin Kočí
>            Assignee: Martin Kočí
>             Fix For: 2.0.8, 2.1.2
>
>         Attachments: MYFACES-3234.patch
>
>
> example: 
> CodiFacesContextWrapper extends FacesContextWrapper
> org.apache.myfaces.context.servlet.FacesContextImpl.getPartialViewContext():
> _partialViewContext = factory.getPartialViewContext(this)
> -> partial view context is created always with FacesContextImpl instance not with
the wrapped one

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

Mime
View raw message