myfaces-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Leonardo Uribe (JIRA)" <...@myfaces.apache.org>
Subject [jira] [Resolved] (MYFACES-2889) [PERF] Remove String.intern() calls in FlashELResolver and ImplicitObjectResolver
Date Sat, 23 Jul 2011 00:01:10 GMT

     [ https://issues.apache.org/jira/browse/MYFACES-2889?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Leonardo Uribe resolved MYFACES-2889.
-------------------------------------

       Resolution: Fixed
    Fix Version/s: 2.1.2
                   2.0.8
         Assignee: Leonardo Uribe

> [PERF] Remove String.intern() calls in FlashELResolver and ImplicitObjectResolver
> ---------------------------------------------------------------------------------
>
>                 Key: MYFACES-2889
>                 URL: https://issues.apache.org/jira/browse/MYFACES-2889
>             Project: MyFaces Core
>          Issue Type: Improvement
>          Components: JSR-314
>    Affects Versions: 2.0.2-SNAPSHOT
>         Environment: JBoss AS 6 M4, Parleys.com JSF2 app
>            Reporter: Jan-Kees van Andel
>            Assignee: Leonardo Uribe
>             Fix For: 2.0.8, 2.1.2
>
>
> I've been doing some profiling and I see pretty much activity in FlashELResolver.castAndIntern()
and ImplicitObjectResolver.castAndIntern().
> When I replace the "return s.intern()" lines by  "return s", both methods have (of course)
much better performance.
> But I'm pretty sure someone put them there with a reason, like memory footprint.
> However, I don't see any difference in memory footprint.
> Any ideas? Do we want to keep the intern() calls?

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message