Mailing-List: contact dev-help@myfaces.apache.org; run by ezmlm
Precedence: bulk
Reply-To: "MyFaces Development" <dev@myfaces.apache.org>
Date: Wed, 13 Apr 2011 17:36:05 +0000 (UTC)
From: "Jeanne Waldman (JIRA)" <dev@myfaces.apache.org>
To: dev@myfaces.apache.org
Message-ID: 
 <336032756.55617.1302716165922.JavaMail.tomcat@hel.zones.apache.org>
In-Reply-To: 
 <1842824817.6439.1296691709423.JavaMail.tomcat@hel.zones.apache.org>
Subject: [jira] [Commented] (TRINIDAD-2026) memory leak in skinstyleprovider
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/TRINIDAD-2026?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13019448#comment-13019448 ] 

Jeanne Waldman commented on TRINIDAD-2026:
------------------------------------------

This patch does not clear out _document off the Skin. SkinFactory#_FACTORIES is holding on to StyleSheetNodes. We register all
skins with the SkinFactory. Once a skin has been requested by the user, we parse the stylesheet and store the stylesheetnodes with the skin. This is TRINIDAD-2087

> memory leak in skinstyleprovider
> --------------------------------
>
>                 Key: TRINIDAD-2026
>                 URL: https://issues.apache.org/jira/browse/TRINIDAD-2026
>             Project: MyFaces Trinidad
>          Issue Type: Improvement
>            Reporter: Jeanne Waldman
>         Attachments: LRUCache.patch
>
>
> There is no limit to the size of the providers cache  in
> SkinStyleProvider.java. Every time we ask for a new skin, we add to the
> provider cache.
> A skin has StyleSheetDocument and StyleSheetDocument has StyleSheetNodes. If
> we remove a skin from the cache, we will need to clear out its _document,
> which in turn will clear out the StyleSheetNodes. StyleSheetNodes are the
> parsed representation of the skin css file.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira