myfaces-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Andrew Robinson (JIRA)" <...@myfaces.apache.org>
Subject [jira] [Reopened] (TRINIDAD-2047) UIXCollection saves the stamp state when there is no stamp
Date Tue, 26 Apr 2011 16:15:03 GMT

     [ https://issues.apache.org/jira/browse/TRINIDAD-2047?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Andrew Robinson reopened TRINIDAD-2047:
---------------------------------------


The fix was an incorrect one. Due to my misunderstanding of the code due to a lack of comments,
it seems that there is a valid reason why the non-stamped state is being saved as a stamped
state. This is the only code that saves off the virgin state of the child components. My change
is causing the nested state to not be cleared from the children components once the row key
is set back to null (-1 row index). This is especially bad with nested collections, as the
nested row stamp state object is not cleared and thus nested collections may end up sharing
their stamp state across parent rows.

> UIXCollection saves the stamp state when there is no stamp
> ----------------------------------------------------------
>
>                 Key: TRINIDAD-2047
>                 URL: https://issues.apache.org/jira/browse/TRINIDAD-2047
>             Project: MyFaces Trinidad
>          Issue Type: Bug
>          Components: Components
>    Affects Versions: 1.2.14-core , 2.0.0-beta-2
>            Reporter: Andrew Robinson
>            Assignee: Andrew Robinson
>             Fix For: 1.2.15-core , 2.0.0
>
>
> UIXCollection in the preRowDataChange saves the current stamp state. The problem is that
the code does not check to see if there is a current stamp. The result, is child components
may not correctly function if they expect to be inside a valid stamp. What happens is that
when the collection first sets its row key/index, the stamp state is saved for index -1 (row
key null). Children components that assume that the collection is processing a stamp may error
out. There should be no reason why the stamp state is being saved when there is no stamp.
> I have come across user's of our code where they are getting exceptions in their code
as a result.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message