myfaces-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Gerhard Petracek (JIRA)" <...@myfaces.apache.org>
Subject [jira] [Commented] (EXTCDI-162) re-visit implementation of custom project stages.
Date Sat, 09 Apr 2011 10:38:06 GMT

    [ https://issues.apache.org/jira/browse/EXTCDI-162?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13017830#comment-13017830
] 

Gerhard Petracek commented on EXTCDI-162:
-----------------------------------------

currently we have

4 +1 for an autom. veto (+ logging)
1 +1 for a new explicit annotation as alternative to @Typed() btw. keep it as it is

i'll commit the fix (preferred by the majority) by the end of next week.
if someone feels that this result isn't representative, please feel free to start a discussion
on the dev-list.

> re-visit implementation of custom project stages.
> -------------------------------------------------
>
>                 Key: EXTCDI-162
>                 URL: https://issues.apache.org/jira/browse/EXTCDI-162
>             Project: MyFaces CODI
>          Issue Type: Task
>          Components: Core
>    Affects Versions: 0.9.4
>            Reporter: Gerhard Petracek
>
> if users forget @Typed(), they would see an AmbiguousResolutionException.
> cdi-qualifiers aren't supported (in case of project-stages). so @Typed() is required
all the time.
> currently valid example:
> public class CustomProjectStage implements ProjectStageHolder
> {
>     @Typed()
>     public static final class Debugging extends ProjectStage
>     {
>         private static final long serialVersionUID = -8626602281649294170L;
>     }
>     public static final Debugging Debugging = new Debugging();
> }
> since there is no support for cdi-qualifiers, we could veto those classes. that would
allow to skip the @Typed() but the rest would be the same (because codi will still find them).
> pro: users don't have to use @Typed() explicitly (and they won't see the AmbiguousResolutionException,
if they forget using @Typed())
> con: it isn't std. cdi - but adding @Typed() even though it isn't needed wouldn't harm.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message