myfaces-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Andy Schwartz (JIRA)" <...@myfaces.apache.org>
Subject [jira] [Resolved] (TRINIDAD-2078) SKIP_ITERATION forces visit of non-rendered components
Date Thu, 14 Apr 2011 00:58:05 GMT

     [ https://issues.apache.org/jira/browse/TRINIDAD-2078?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Andy Schwartz resolved TRINIDAD-2078.
-------------------------------------

       Resolution: Fixed
    Fix Version/s: 2.0.0-beta-3

> SKIP_ITERATION forces visit of non-rendered components
> ------------------------------------------------------
>
>                 Key: TRINIDAD-2078
>                 URL: https://issues.apache.org/jira/browse/TRINIDAD-2078
>             Project: MyFaces Trinidad
>          Issue Type: Bug
>          Components: Components
>    Affects Versions: 2.0.0-beta-2
>            Reporter: Andy Schwartz
>            Assignee: Blake Sullivan
>             Fix For: 2.0.0-beta-3
>
>         Attachments: trin2078_trin2.diff, trinidad-2078.diff
>
>
> Certain tree visits, such as the PostRestoreStateEvent delivery visit, must avoid iteration
in stamping components (eg. UIData).  Before the fix for:
> TRINIDAD-2030 Honor SKIP_ITERATION FacesContext property
> This was handled in UIXComponent.visitChildren() by checking for the restore view phase.
> As of the fix for 2030, instead of checking the phase id we now check for the SKIP_ITERATION
pseudo-hint.
> While this works correctly for the PostRestoreStateEvent visit, it fails in other cases.
 The problem: UIXComponent.visitChildren() falls back on a "facets and children" traversal
when SKIP_ITERATION is set, which means that we will visit all children (both rendered and
non-rendered) even when the SKIP_UNRENDERED hint is set.
> Thus, the combination of SKIP_ITERATION and SKIP_UNRENDERED is not correctly supported
with our current solution.  Since this is a valid combination of hints, we'll need an approach
that correctly supports this.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message