myfaces-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Gerhard Petracek <gerhard.petra...@gmail.com>
Subject Re: [jira] [Commented] (EXTCDI-162) re-visit implementation of custom project stages.
Date Mon, 28 Mar 2011 13:58:39 GMT
yes - that would be possible.
furthermore, users can still use @Typed() (if they would like to) - the
result will be the same.

regards,
gerhard

http://www.irian.at

Your JSF powerhouse -
JSF Consulting, Development and
Courses in English and German

Professional Support for Apache MyFaces



2011/3/28 Bart Kummel (JIRA) <dev@myfaces.apache.org>

>
>    [
> https://issues.apache.org/jira/browse/EXTCDI-162?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13012060#comment-13012060]
>
> Bart Kummel commented on EXTCDI-162:
> ------------------------------------
>
> I think it is always a good idea to make things more simple for the users.
> On the other hand, implicit actions or assumptions might be confusing
> sometimes. I think this type of confusion can be prevented by generating a
> log entry, stating that "a @Typed annotation is implicitly applied" or
> something like that.
>
> > re-visit implementation of custom project stages.
> > -------------------------------------------------
> >
> >                 Key: EXTCDI-162
> >                 URL: https://issues.apache.org/jira/browse/EXTCDI-162
> >             Project: MyFaces CODI
> >          Issue Type: Task
> >          Components: Core
> >    Affects Versions: 0.9.4
> >            Reporter: Gerhard Petracek
> >
> > if users forget @Typed(), they would see an AmbiguousResolutionException.
> > cdi-qualifiers aren't supported (in case of project-stages). so @Typed()
> is required all the time.
> > currently valid example:
> > public class CustomProjectStage implements ProjectStageHolder
> > {
> >     @Typed()
> >     public static final class Debugging extends ProjectStage
> >     {
> >         private static final long serialVersionUID =
> -8626602281649294170L;
> >     }
> >     public static final Debugging Debugging = new Debugging();
> > }
> > since there is no support for cdi-qualifiers, we could veto those
> classes. that would allow to skip the @Typed() but the rest would be the
> same (because codi will still find them).
> > pro: users don't have to use @Typed() explicitly (and they won't see the
> AmbiguousResolutionException, if they forget using @Typed())
> > con: it isn't std. cdi - but adding @Typed() even though it isn't needed
> wouldn't harm.
>
> --
> This message is automatically generated by JIRA.
> For more information on JIRA, see: http://www.atlassian.com/software/jira
>

Mime
View raw message