myfaces-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Michael Freedman (JIRA)" <...@myfaces.apache.org>
Subject [jira] [Commented] (PORTLETBRIDGE-202) Proposal for 3.0 IMPL: Support mode changes via StateAwareResponse#setPortletMode(PortletMode)
Date Wed, 30 Mar 2011 20:25:05 GMT

    [ https://issues.apache.org/jira/browse/PORTLETBRIDGE-202?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13013627#comment-13013627
] 

Michael Freedman commented on PORTLETBRIDGE-202:
------------------------------------------------

1) On your spec comment -- I don't see why the spec would need to say anything about this
specific use case.  I think (hope) the spec is clear as to the bridge behavior when it encounters
a mode change in any request -- i.e. don't restore the scope.  

2) On managing this info in the requestScope itself.  Maybe -- right now the RI handles this
by encoding the info in the target viewId itself.  This ensures that whenever we are processing
an incoming request that the target can check  what mode it was "saved" in and the bridge
controller only restores if that mode is the same as the current request.  Seems to me this
is a logical place to handle things (i.e. in the controller itself) as why should the bridge
restore the scope so it can read the mode and then decide to undo the restore beacuse the
mode has changed?

> Proposal for 3.0 IMPL: Support mode changes via StateAwareResponse#setPortletMode(PortletMode)
> ----------------------------------------------------------------------------------------------
>
>                 Key: PORTLETBRIDGE-202
>                 URL: https://issues.apache.org/jira/browse/PORTLETBRIDGE-202
>             Project: MyFaces Portlet Bridge
>          Issue Type: New Feature
>          Components: General
>    Affects Versions: 3.0.0
>            Reporter: Neil Griffin
>            Assignee: Michael Freedman
>
> To the best of my knowledge, the Bridge 2.0 spec does not address usage of StateAwareResponse#setPortletMode(PortletMode)
within a JSF backing bean action.
> This proposal would require the BridgeRequestScope to remember the PortletMode so that
mode changes can be detected:
> public interface BridgeRequestScope {
> 	...
> 	PortletMode getPortletMode();
> 	void setPortletMode(PortletMode portletMode);
> 	...
> }
> Note that the Bridge implementation would be required to call bridgeRequestScope.setPortletMode()
during an ActionRequest and EventRequest.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message