myfaces-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Prakash Udupa (JIRA)" <...@myfaces.apache.org>
Subject [jira] Commented: (TRINIDAD-2050) NO GOOD DIAGNOSTIC MESSAGE FROM SKINNING FRAMEWORK FOR CASE OF BLANK TRINIDAD-SKINS.XML
Date Mon, 07 Mar 2011 18:36:59 GMT

    [ https://issues.apache.org/jira/browse/TRINIDAD-2050?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13003497#comment-13003497
] 

Prakash Udupa commented on TRINIDAD-2050:
-----------------------------------------

_META_INF_CONFIG_FILE is a constant string 'META-INF/trinidad-skins.xml'
url.toString() will lead me to the complete path of the trinidad-skins.xml (includes the jar
from where it was read). This is more useful for anyone that reads the error message to go
back and spot which file has the issue and fix it.

> NO GOOD DIAGNOSTIC MESSAGE FROM SKINNING FRAMEWORK FOR CASE OF BLANK TRINIDAD-SKINS.XML
> ---------------------------------------------------------------------------------------
>
>                 Key: TRINIDAD-2050
>                 URL: https://issues.apache.org/jira/browse/TRINIDAD-2050
>             Project: MyFaces Trinidad
>          Issue Type: Bug
>          Components: Skinning
>    Affects Versions: 2.0.0-beta-3
>            Reporter: Prakash Udupa
>            Assignee: Jeanne Waldman
>         Attachments: JIRA_2050_empty_skin_config_issue.patch
>
>   Original Estimate: 24h
>  Remaining Estimate: 24h
>
> There is possibility of a trinidad-skin.xml in the class path being without any content,
mostly due to packaging errrors. In this circumstance, the XML parser callback and error handler
implementations in Trinidad just logs the entire stack trace of the SAXException, with no
indication of the xml file that fails, this makes it hard to diagnose given that there could
be multiple config files that get merged. We need a more informative log message, even better
if the message contained the complete path to the specific trinidad-skins.xml file that has
the issue.
> Here is a sample exception logged that does not provide much useful information:
> ---------------------------------------------------------------------------------------------------------------------
> <TreeBuilder$Handler> <_logError> Parsing error, line 1, column 1: 
> org.xml.sax.SAXParseException: Premature end of file.
> 	at com.sun.org.apache.xerces.internal.util.ErrorHandlerWrapper.createSAXParseException(ErrorHandlerWrapper.java:195)
> 	at com.sun.org.apache.xerces.internal.util.ErrorHandlerWrapper.fatalError(ErrorHandlerWrapper.java:174)
> 	at com.sun.org.apache.xerces.internal.impl.XMLErrorReporter.reportError(XMLErrorReporter.java:388)
> 	at com.sun.org.apache.xerces.internal.impl.XMLScanner.reportFatalError(XMLScanner.java:1414)
> 	at com.sun.org.apache.xerces.internal.impl.XMLDocumentScannerImpl$PrologDriver.next(XMLDocumentScannerImpl.java:1059)
> 	at com.sun.org.apache.xerces.internal.impl.XMLDocumentScannerImpl.next(XMLDocumentScannerImpl.java:648)
> 	at com.sun.org.apache.xerces.internal.impl.XMLNSDocumentScannerImpl.next(XMLNSDocumentScannerImpl.java:140)
> 	at com.sun.org.apache.xerces.internal.impl.XMLDocumentFragmentScannerImpl.scanDocument(XMLDocumentFragmentScannerImpl.java:511)
> 	at com.sun.org.apache.xerces.internal.parsers.XML11Configuration.parse(XML11Configuration.java:808)
> 	at com.sun.org.apache.xerces.internal.parsers.XML11Configuration.parse(XML11Configuration.java:737)
> 	at com.sun.org.apache.xerces.internal.parsers.XMLParser.parse(XMLParser.java:119)
> 	at com.sun.org.apache.xerces.internal.parsers.AbstractSAXParser.parse(AbstractSAXParser.java:1205)
> 	at com.sun.org.apache.xerces.internal.jaxp.SAXParserImpl$JAXPSAXParser.parse(SAXParserImpl.java:522)
> 	at weblogic.xml.jaxp.WebLogicXMLReader.parse(WebLogicXMLReader.java:133)
> 	at weblogic.xml.jaxp.RegistryXMLReader.parse(RegistryXMLReader.java:173)
> 	at org.apache.myfaces.trinidadinternal.share.xml.TreeBuilder.parse(TreeBuilder.java:169)
> 	at org.apache.myfaces.trinidadinternal.share.xml.TreeBuilder.parse(TreeBuilder.java:120)
> 	at org.apache.myfaces.trinidadinternal.skin.SkinUtils._getSkinsNodeFromInputStream(SkinUtils.java:256)

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message