myfaces-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Scott O'Bryan (JIRA)" <...@myfaces.apache.org>
Subject [jira] Issue Comment Edited: (TRINIDAD-2046) Copying data from inputStream to OuputStream needs appropriate buffer size
Date Tue, 01 Mar 2011 17:11:37 GMT

    [ https://issues.apache.org/jira/browse/TRINIDAD-2046?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13000966#comment-13000966
] 

Scott O'Bryan edited comment on TRINIDAD-2046 at 3/1/11 5:10 PM:
-----------------------------------------------------------------

I read the parent bug and took a look at the patch.  You're basically saying that the buffer
should be the size of the content with a MAXIMUM_SIZE equal to 1024 bytes?

Do you have a patch that you tried to show this fix had a significant improvement over the
existing implementation?

      was (Author: darkarena):
    Okay, I re-read the parent bug and took a look at the patch.  You're basically saying
that the buffer should be the size of the content with a MAXIMUM_SIZE equal to 1024 bytes.

Do you have a patch that you tried to show this fix had a significant improvement over the
existing implementation?
  
> Copying data from inputStream to OuputStream needs appropriate buffer size
> --------------------------------------------------------------------------
>
>                 Key: TRINIDAD-2046
>                 URL: https://issues.apache.org/jira/browse/TRINIDAD-2046
>             Project: MyFaces Trinidad
>          Issue Type: Improvement
>          Components: Components
>    Affects Versions: 1.2.14-core , 2.0.0-beta-2
>            Reporter: Xiaoming Shi
>              Labels: performance
>
> In the files 
> ./trinidad-1.2.14/trinidad-impl/src/main/java/org/apache/myfaces/trinidadinternal/image/cache/FileSystemImageCache.java
  line:955    
> ./trinidad-1.2.14/trinidad-impl/src/main/java/org/apache/myfaces/trinidadinternal/image/painter/ImageUtils.java
               line:303           
> The buffer size is fixed as 1024 bytes. With the size of the data varies, the performance
can be damaged a lot.
> We need an appropriate buffer size which depends on the size of the data to be copied.
> This is the same as the Appache Bug (https://issues.apache.org/bugzilla/show_bug.cgi?id=32546)

-- 
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message