myfaces-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Rudy De Busscher (JIRA)" <...@myfaces.apache.org>
Subject [jira] [Commented] (EXTCDI-162) re-visit implementation of custom project stages.
Date Tue, 29 Mar 2011 08:11:05 GMT

    [ https://issues.apache.org/jira/browse/EXTCDI-162?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13012377#comment-13012377
] 

Rudy De Busscher commented on EXTCDI-162:
-----------------------------------------

We should help the developer as much as possible.  The fact that there is already a method
producing this kind of bean is only known to a small group of people (basicly the the commiters)
and the solution (adding @Typed) is not very known also (I think most developers just known
the basic things like @Inject, @Named and the Scopes and that is about all).

But when we do the magic ourselves, there should be a message in the log so that people can
learn from it.


> re-visit implementation of custom project stages.
> -------------------------------------------------
>
>                 Key: EXTCDI-162
>                 URL: https://issues.apache.org/jira/browse/EXTCDI-162
>             Project: MyFaces CODI
>          Issue Type: Task
>          Components: Core
>    Affects Versions: 0.9.4
>            Reporter: Gerhard Petracek
>
> if users forget @Typed(), they would see an AmbiguousResolutionException.
> cdi-qualifiers aren't supported (in case of project-stages). so @Typed() is required
all the time.
> currently valid example:
> public class CustomProjectStage implements ProjectStageHolder
> {
>     @Typed()
>     public static final class Debugging extends ProjectStage
>     {
>         private static final long serialVersionUID = -8626602281649294170L;
>     }
>     public static final Debugging Debugging = new Debugging();
> }
> since there is no support for cdi-qualifiers, we could veto those classes. that would
allow to skip the @Typed() but the rest would be the same (because codi will still find them).
> pro: users don't have to use @Typed() explicitly (and they won't see the AmbiguousResolutionException,
if they forget using @Typed())
> con: it isn't std. cdi - but adding @Typed() even though it isn't needed wouldn't harm.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message