myfaces-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jing Wu (JIRA)" <...@myfaces.apache.org>
Subject [jira] Commented: (TRINIDAD-2021) Wrong behavior in TrNumberFormat
Date Tue, 01 Feb 2011 19:51:29 GMT

    [ https://issues.apache.org/jira/browse/TRINIDAD-2021?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12989353#comment-12989353
] 

Jing Wu commented on TRINIDAD-2021:
-----------------------------------

to see the problem, run the following script in your browser debug console window:

var numFormat = TrNumberFormat.getNumberInstance(null);
numFormat.setMaximumFractionDigits(3);
numFormat.setMinimumFractionDigits(3);
numFormat.format("1.1234");

It will return "1.1234" instead of "1.123".

> Wrong behavior in TrNumberFormat
> --------------------------------
>
>                 Key: TRINIDAD-2021
>                 URL: https://issues.apache.org/jira/browse/TRINIDAD-2021
>             Project: MyFaces Trinidad
>          Issue Type: Bug
>          Components: Components
>    Affects Versions: 1.2.13-core 
>         Environment: Environment independent.
>            Reporter: Jing Wu
>            Priority: Minor
>         Attachments: numberformat.patch
>
>
> Currently implementation of formatting a fraction part of a number is shown below: when
maxFra is the same as minFra, and facsLength is larger than maxFra, the number will not be
formatted correctly.
> TrNumberFormat.prototype._formatFractions = function(fracs)
> {
>   var fracsLength = fracs.length;
>   var maxFra = this.getMaximumFractionDigits();
>   var minFra = this.getMinimumFractionDigits();
>   if(fracsLength > maxFra && maxFra>minFra)
>   {
>     fracs = fracs.substring(0, maxFra);
>   }
>   if(fracsLength <minFra)
>   {
>     var gap = minFra-fracsLength;
>     
>     //we need to add some zeros
>     while(gap>0)
>     {
>       fracs = fracs + "0";
>       --gap;
>     }
>   }
>   return fracs;
> }
> The 7th line of the above code should be:
>   if(fracsLength > maxFra && maxFra >= minFra)

-- 
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message