myfaces-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Leonardo Uribe (JIRA)" <...@myfaces.apache.org>
Subject [jira] Commented: (MYFACES-2995) Make method of determinine app context in FactoryFinder pluggable
Date Sun, 20 Feb 2011 05:07:38 GMT

    [ https://issues.apache.org/jira/browse/MYFACES-2995?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12996973#comment-12996973
] 

Leonardo Uribe commented on MYFACES-2995:
-----------------------------------------

The example of the EAR is just a "help" to understand the problem, but it is not a limitation.
The important concept is FactoryFinderProviderFactory instance is an static var that should
be initialized when the "classloader context" is initialized. For example, if I have 5 EAR
files and all share the same myfaces implementation (by some specific classloading configuration
done by the server), the container should initialize this instance before deploy/start any
of the 5 EAR.

I was thinking on make some changes on FactoryFinderProviderFactory, removing the code that
set FactoryFinder._initialized to false. Instead, check if FactoryFinder has been initialized
and if that so, log a warning indicating the instance will not be changed.

I'll be pending of your review so we can close this issue.

> Make method of determinine app context in FactoryFinder pluggable
> -----------------------------------------------------------------
>
>                 Key: MYFACES-2995
>                 URL: https://issues.apache.org/jira/browse/MYFACES-2995
>             Project: MyFaces Core
>          Issue Type: Improvement
>          Components: SPI
>    Affects Versions: 2.0.3-SNAPSHOT
>            Reporter: David Jencks
>         Attachments: MYFACES-2995-FactoryFinderProvider-1.patch, MYFACES-2995.patch
>
>
> As discussed on dev list.... geronimo would like to explicitly mark component boundaries
rather than relying on the TCCL changing.

-- 
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message